Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork5.3k
Added documentation about profiler matchers#2785
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
cookbook/profiler/matchers.rst Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
wants
wouterj commentedJul 8, 2013
we should keep track ofsymfony/symfony#8352 and change it on the master branch |
weaverryan commentedJul 28, 2013
Hey Wouter! So, this is a really nice entry. BUT, the original issue was not a good one. This feature is actually already documented, here:http://symfony.com/doc/current/book/internals.html#configuration Now, I think it's better to have this as a standalone cookbook entry, but since the documentation exists, we need to tweak few things with this PR:
@wouterj - can you make these changes? Thanks! |
cookbook/profiler/matchers.rst Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Wrong wrapping
wouterj commentedJul 29, 2013
"the original issue was not a good one" And do you really think it's needed to add a path example? I'll add some information in the paragraph about the path option and fix (1) this afternoon. |
weaverryan commentedAug 10, 2013
Merged! Minor tweaks at sha:826197b. This reads very well and I like the example you chose. Thanks Wouter! |