Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork5.2k
cleaning#2753
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
cleaning#2753
Uh oh!
There was an error while loading.Please reload this page.
Conversation
[Components][Console] Fixed typos for table helper
Made the Icu component compatible with ICU 3.8
Adding lazy services documentation as ofsymfony/symfony#7890
Conflicts:components/yaml/introduction.rst
Conflicts:components/yaml/introduction.rst
| public function isEqualTo(UserInterface $user) | ||
| { | ||
| return $this->id === $user->getId(); | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
AFAIK, this code is stil relevant. But an explanation/introduction should be placed before this snippet
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
totally agree. i personally dont know what is this code good for and it was not needed to make functionality covered by this tutorial to work, so from my perspective it is useless, unless ofc the explanation will be added. i would suggest remove the code for now, and once someone decide to add explanation, the code can be attached again.
Great job and really fast responses! Thank you! Except from the last comment: 👍 (if you know how to do it, can you please squash the commits?) |
i've fixed the last comment. thanks On 23.6.2013 21:18, Wouter J wrote:
|
Ryan will merge it when you say it's ready. And don't worry about the amount of comments, it's quite normal to have some fixes because people are used to write MarkDown and not ReStructuredText |
:) On 23.6.2013 21:27, Wouter J wrote:
|
| ->select('u,g') | ||
| ->leftJoin('u.groups', 'g') | ||
| ->select('u,r') | ||
| ->leftJoin('u.roles', 'R') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
ther should be lowercased, as you use it lowercased on the previous line
for more info see#2756
squashed pull request is here#2765 |
removed some random, unexplained and possibly unrelated code