Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[book] Avoid scrollbars in code examples#2749

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
weaverryan merged 1 commit intosymfony:2.2fromwouterj:book_examples_scroll
Jun 30, 2013

Conversation

@wouterj
Copy link
Member

QA
Doc fix?yes
New docs?no
Applies toall
Fixed tickets-

There is one thing I'm not sure about and that thing are the wrapped commands:

$ php app/console generate:bundle AcmeFooBundle \--dir src --format yaml

I don't know if it is commonly known that the\ character can be used for multiline commands

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

for me, I think the example would be more readable if further lines are indented like this:

$ php app/console doctrine:generate:entity \  --entity="AcmeStoreBundle:Product" \  --fields="name:string(255) price:float description:text"

weaverryan added a commit that referenced this pull requestJun 30, 2013
[book] Avoid scrollbars in code examples
@weaverryanweaverryan merged commitae25cdb intosymfony:2.2Jun 30, 2013
weaverryan added a commit that referenced this pull requestJun 30, 2013
This is technically correct, and prevents the scrollbar online, but I don't want to confuse any users with these
@weaverryan
Copy link
Member

Hey Wouter!

Very nice! You're absolutely correct with your use of\ in the commands, but as I don't want to confuse any users, I reversed most of these at sha:dcf2c27

Thanks!

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@wouterj@weaverryan@xabbuh

[8]ページ先頭

©2009-2025 Movatter.jp