Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork5.3k
[WCM] Fix example code to reflect changes for #8226#2741
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
alcaeus commentedJun 19, 2013
| Q | A |
|---|---|
| Doc fix? | yes |
| New docs? | PRsymfony/symfony#8283 |
| Applies to | 2.1, 2.2, 2.3 |
| Fixed tickets | symfony/symfony#8226 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
could you please do some line wrapping to avoid horizontal scrollbars?
alcaeus commentedJun 19, 2013
In that case we should probably refactor the entire source code and trim all lines to ~80 characters. That's how many I can see when looking at the Symfony docs. |
wouterj commentedJun 19, 2013
@alcaeus well, it's one of our standards in the docs to try to avoid crossing the 80th character in code blocks. But I never did a PR to fix all examples. However, are you sure the null check wasn't worth it? We can also split the condition on multiple lines. |
alcaeus commentedJun 19, 2013
Alright, I'll split it tomorrow. |
stof commentedJun 19, 2013
@wouterj being different than |
…ly clear their own tokens
alcaeus commentedJun 22, 2013
WouterJ: I've checked - 80 characters really doesn't make any sense here, since even with splitting there are quite a few lines that break an 80 character gutter. Let me know if I should still go ahead and split as much as possible or if we'll just leave it like that for now. |
wouterj commentedJun 22, 2013
well, let's do it this way in this PR. I'll fix it in another PR sometime... |
alcaeus commentedJul 19, 2013
Replaced by PR#2835 |