Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[WCM] Fix example code to reflect changes for #8226#2741

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed
alcaeus wants to merge1 commit intosymfony:2.1fromalcaeus:ticket_8226

Conversation

@alcaeus
Copy link
Contributor

QA
Doc fix?yes
New docs?PRsymfony/symfony#8283
Applies to2.1, 2.2, 2.3
Fixed ticketssymfony/symfony#8226

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

could you please do some line wrapping to avoid horizontal scrollbars?

@alcaeus
Copy link
ContributorAuthor

In that case we should probably refactor the entire source code and trim all lines to ~80 characters. That's how many I can see when looking at the Symfony docs.
Also, this horizontal scrolling applies to pretty much every doc page.

@wouterj
Copy link
Member

@alcaeus well, it's one of our standards in the docs to try to avoid crossing the 80th character in code blocks. But I never did a PR to fix all examples.

However, are you sure the null check wasn't worth it? We can also split the condition on multiple lines.

@alcaeus
Copy link
ContributorAuthor

Alright, I'll split it tomorrow.
The removed null check is per a suggestion in the Symfony PR, I merely updated the docs to reflect that change.

@stof
Copy link
Member

@wouterj being different thannull is already catched by the instanceof check

@alcaeus
Copy link
ContributorAuthor

WouterJ: I've checked - 80 characters really doesn't make any sense here, since even with splitting there are quite a few lines that break an 80 character gutter. Let me know if I should still go ahead and split as much as possible or if we'll just leave it like that for now.
I've also squashed my two commits in a single one for better readibility.

@wouterj
Copy link
Member

well, let's do it this way in this PR. I'll fix it in another PR sometime...

@alcaeus
Copy link
ContributorAuthor

Replaced by PR#2835

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@alcaeus@wouterj@stof

[8]ページ先頭

©2009-2025 Movatter.jp