symfony/symfony-docsPublic

NotificationsYou must be signed in to change notification settings
Fork5.3k
Star2.3k

Update how to add custom Type#2725

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Closed

metfan wants to merge2 commits intosymfony:2.3frommetfan:patch-1

Closed

Update how to add custom Type#2725

metfan wants to merge2 commits intosymfony:2.3frommetfan:patch-1

Conversation

Copy link

metfan commentedJun 13, 2013

Since 2.3, we can't use anymore $this->factory->addType() t add custom Type to factory. We have to use PreloadedExtension class.

Update how to add custom Type

a82e41c

New in sf2.3, update the way we have to use to add custom Type.

metfan mentioned this pull request

Jun 13, 2013

[Cookbook][Form testing] update sf2.3 way to add custom tupe#2724

Closed

wouterj reviewed

Jun 13, 2013

View reviewed changes

cookbook/form/unit_testing.rst Outdated

Copy link

Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

this should be indented one level less

Copy link

Member

wouterj commentedJun 13, 2013

I made some comments, but except from those I'm +1. What you need to do to fix those comments is going tohttp://github.com/metfan/symfony-docs/tree/patch-1 then go to the file, edit it and commit it.

fix indent & coma

20a00a4

Copy link

Contributor

marekkalnik commentedJun 20, 2013

👍

Copy link

Member

velovint commentedJun 28, 2013

ship it

weaverryan added a commit that referenced this pull request

Jun 30, 2013

[#2725] Fixing whitespace

24b184b

weaverryan mentioned this pull request

Jun 30, 2013

Fix for #2485#2681

Closed

Copy link

Member

weaverryan commentedJun 30, 2013

Hey Ulrich and everyone else!

This looks awesome - very nice work! It looks like this is a valid solution all the way back to at least Symfony 2.2 (which is the oldest version we are supporting and care about). So, I've patched this into the 2.2 branch at sha:83641f8 and sha:755065f

Thanks!