Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Fix for #2485#2681

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed
Stubbs wants to merge1 commit intosymfony:2.1fromStubbs:fix-issue-2485
Closed

Fix for #2485#2681

Stubbs wants to merge1 commit intosymfony:2.1fromStubbs:fix-issue-2485

Conversation

@Stubbs
Copy link

QA
Doc fix?yes
New docs?no
Applies to2.1+
Fixed tickets#2485

Fixes the documented example of how to test forms with custom types,
as there was no better suggestions than the one put forward by
@chrisburgess7 I implemented that in my test case & it worked so
I've updated the documentation to match.

(Resubmitted against the proper branch)

| ------------- | ---| Doc fix?      | yes| New docs?     | no| Applies to    | 2.1+| Fixed tickets | 2485Fixes the documented example of how to test forms with custom types,as there was no better suggestions than the one put forward by@chrisburgess7 I implemented that in my test case & it worked soI've updated the documentation to match.
@weaverryan
Copy link
Member

Hi Stuart!

Thanks for taking on this fix! What do you think about this approach instead:#2485 (comment). It seems truer to the intention of the change (e.g.Use form extensions or type registration in the Dependency Injection Container instead.).

Thanks!

@weaverryan
Copy link
Member

Hey Stuart!

Someone has already fixed this with an approach similar to the one I just pointed out (#2725). I look forward to seeing other contributions from you soon! ;)

Thanks!

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Stubbs@weaverryan

[8]ページ先頭

©2009-2025 Movatter.jp