Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork5.2k
update cookbook for couch and phpcr and give some more hints and background#2669
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
| $container->addCompilerPass( | ||
| DoctrinCouchDBMappingsPass::createXmlMappingDriver( | ||
| $mappings, 'fos_user.backend_type_couchdb' | ||
| )); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
$container->addCompilerPass( DoctrineCouchDBMappingsPass::createXmlMappingDriver($mappings,'fos_user.backend_type_couchdb' ));
thanks for the feedback, fixed all 4 issues. |
| . '\Compiler\DoctrineCouchDBMappingsPass'; | ||
| if (class_exists($couchCompilerClass)) { | ||
| $container->addCompilerPass( | ||
| DoctrinCouchDBMappingsPass::createXmlMappingDriver( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Typo DoctrineCouchDBMappingsPass
ups, fixed and made Doctrine consistently uppercase |
👍 (could you please squash?) Nice to see another gab filled with some content! |
squashed the commits |
any reason not to merge this? |
No. I just think Ryan didn't get to this PR. He often wants to test these big PRs before merging and that means some more time than the minor typo fix PRs. |
ah ok then. would have been bad if we each wait on the other to act :-) and i start referring people to that cookbook entry and then noticed its not complete yet... |
| And place your mapping file into `/Resources/config/doctrine-base` with the | ||
| fully qualified class name, separated by `.` instead of `\\`, for example | ||
| `Other.Namespace.Model.Name.orm.xml`. You may not mix the two as otherwise | ||
| the SymfonyFileLocator will get confused. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
oh ups. on the plus side of this being not yet merged: i just detected i did not update after discovering an issue i had.
@beberlei do you have any input on this, does it make sense to recommend this solution?
…ground, fix cs and some typos
right, thanks for the inputs WouterJ. fixed and squashed again. |
| And place your mapping file into ``/Resources/config/doctrine-base`` with the | ||
| fully qualified class name, separated by ``.`` instead of ``\``, for example | ||
| ``Other.Namespace.Model.Name.orm.xml``. You may not mix the two as otherwise | ||
| the SymfonyFileLocator will get confused. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
@beberlei do you have any input on this, does it make sense to recommend this solution?
update cookbook for couch and phpcr and give some more hints and background
1) Fixed missed second argument to the `createXmlMappingDriver` methods2) Clarified the final note about the SymfonyFileLocator3) Other minor changes
Hey David! I've just merged this in - apologies for the delay, I wanted to have some time to actually look and understand this feature. I've made some changes at sha:e55f0f7, which include adding a missing second argument to the Thanks! |
No worries, thanks for the cleanups, seems i did not sync with the changes in the pr. Now lets help people actually can use this |
adding the missing doc for couchdb and phpcr, and giving some more information.