Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork5.3k
Book/Form : Adding a new section about defining forms as service#2667
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
gregquat commentedMay 27, 2013
| Q | A |
|---|---|
| Doc fix? | no |
| New docs? | yes |
| Applies to | all |
| Fixed ticket | - |
| Q | A| ------------- | ---| Doc fix? | no| New docs? | yes| Applies to | all| Fixed ticket | -
book/forms.rst Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
You're defining your form type as a service, not your form
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I specified below "you must tag your form as a form type", do you think I should also change the first sentence?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
A FormType is not a form, but a Type of a form.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Yea. I think you can just drop the second sentence if you fix the first one and then replace occurrences of the word "form" with the words "form type" further on
book/forms.rst Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
make=>makes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Fixed, thank you!
book/forms.rst Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
you should remove the space before the colon
wouterj commentedMay 27, 2013
I like it, but I think it's too long for a book article. What about removing the code examples and only having the first paragraph and the last one (including the link)? |
gregquat commentedMay 27, 2013
Thank you for the review. I'll make the changes. Personnally I like to have example to know immediatety how to use that (and only click on the link if I want more information). I'm agree with the fact the book/form is quite long, but as a book entry, I think it should be complete. So, just tell me if I remove some text/code or not :) |
wouterj commentedMay 27, 2013
I'll let@weaverryan make the final discission ;-) |
Book/Form : Adding a new section about defining forms as service
weaverryan commentedJun 4, 2013
Hi guys! First, thanks Greg for this nice entry. I noticed that wedo talk about the Now, as Wouter mentioned, things are gettingvery busy in here. But, I think for now, we can continue adding things here. At some point, we'll break this into smaller pieces, and then we'll be more "choosy" about this chapter :). Thanks everyone! |
gregquat commentedJun 4, 2013
Thanks you Ryan! |