Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Book/Form : Adding a new section about defining forms as service#2667

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
weaverryan merged 4 commits intosymfony:2.1fromgregquat:patch-15
Jun 4, 2013

Conversation

@gregquat
Copy link
Contributor

QA
Doc fix?no
New docs?yes
Applies toall
Fixed ticket-

| Q             | A| ------------- | ---| Doc fix?      | no| New docs?     | yes| Applies to    | all| Fixed ticket  | -
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

You're defining your form type as a service, not your form

Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I specified below "you must tag your form as a form type", do you think I should also change the first sentence?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

A FormType is not a form, but a Type of a form.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Yea. I think you can just drop the second sentence if you fix the first one and then replace occurrences of the word "form" with the words "form type" further on

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

make=>makes

Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Fixed, thank you!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

you should remove the space before the colon

@wouterj
Copy link
Member

I like it, but I think it's too long for a book article. What about removing the code examples and only having the first paragraph and the last one (including the link)?

@gregquat
Copy link
ContributorAuthor

Thank you for the review. I'll make the changes. Personnally I like to have example to know immediatety how to use that (and only click on the link if I want more information). I'm agree with the fact the book/form is quite long, but as a book entry, I think it should be complete. So, just tell me if I remove some text/code or not :)

@wouterj
Copy link
Member

I'll let@weaverryan make the final discission ;-)

weaverryan added a commit that referenced this pull requestJun 4, 2013
Book/Form : Adding a new section about defining forms as service
@weaverryanweaverryan merged commita9d0e3a intosymfony:2.1Jun 4, 2013
@weaverryan
Copy link
Member

Hi guys!

First, thanks Greg for this nice entry. I noticed that wedo talk about theform.type tag elsewhere, but usually about creating custom form "fields". So, I think your addition makes a lot of sense. I also agree that it should at least be introduced in the main form chapter.

Now, as Wouter mentioned, things are gettingvery busy in here. But, I think for now, we can continue adding things here. At some point, we'll break this into smaller pieces, and then we'll be more "choosy" about this chapter :).

Thanks everyone!

@gregquat
Copy link
ContributorAuthor

Thanks you Ryan!

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@gregquat@wouterj@weaverryan@merk@Burgov

[8]ページ先頭

©2009-2025 Movatter.jp