Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Varnish purge fix#2654

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
weaverryan merged 1 commit intosymfony:2.1fromThijsFeryn:varnish_purge_fix
May 26, 2013
Merged

Conversation

@ThijsFeryn
Copy link

QA
Doc fix?yes
New docs?no
Applies toall (or 2.1+)
Fixed tickets#2653

@hhamon
Copy link
Contributor

Thanks Thijs! Is it possible to add comments in VCL files? Maybe it would be interesting to comment the VCL code for most important sections.

@ThijsFeryn
Copy link
Author

OK, Hugo, I added a bit a comment. Is it good enough like that?

@hhamon
Copy link
Contributor

Looks pretty good thanks. The best would be to squash the commits together. Ping me at the conference if you need help to do it.

@ThijsFeryn
Copy link
Author

Squashed the commits. Ready to merge it?

weaverryan added a commit that referenced this pull requestMay 26, 2013
@weaverryanweaverryan merged commitd248033 intosymfony:2.1May 26, 2013
@weaverryan
Copy link
Member

Wow, this is much more detailed - great idea and execution with the comments. Thanks Thijs!

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ThijsFeryn@hhamon@weaverryan
[8]ページ先頭
©2009-2025 Movatter.jp