Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[DomCrawler] each() iterates over items as Crawlers#2638

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed
julien-c wants to merge2 commits intosymfony:masterfromjulien-c:master

Conversation

julien-c
Copy link
Contributor

QA
Doc fix?yes
New docs?no
Applies to2.3
Fixed tickets#2568

@wouterj
Copy link
Member

Could you please also fix the other things mentioned in#2568 ? And add thepull request format to the pr description?

@julien-c
Copy link
ContributorAuthor

@wouterj PR format added. For thereduce function, there's nothing to do AFAICT, unless you want me to make the example more complex?

@wouterj
Copy link
Member

you're right actually, I never did a good look into that example. I'm 👍 for this, thank you for working on it!

@wouterj
Copy link
Member

One thing though: We can/should add a vesionadded directive mentioning the change. Something like:

..versionadded::2.3    The node argument is a ``Crawler`` instance as of Symfony 2.3.    In prior versions, it was a ``DOMElement`` instance.

@julien-c
Copy link
ContributorAuthor

Do you want me to do it?

@wouterj
Copy link
Member

If you can do it: Yes! Otherwise I'll create a PR

@xabbuh
Copy link
Member

Any news on this topic?

weaverryan added a commit that referenced this pull requestJun 30, 2013
@weaverryan
Copy link
Member

Hi Julien!

Thanks for the nice PR here! I've patched this into the 2.3 branch at sha:ed0920e. You'll notice that some of the changes are missing, only because they have already been done in other PR's. I also added theversionadded and a type-hint at sha:a15a9d5

Thanks!

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

4 participants
@julien-c@wouterj@xabbuh@weaverryan

[8]ページ先頭

©2009-2025 Movatter.jp