Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork5.2k
[DomCrawler] each() iterates over items as Crawlers#2638
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
julien-c commentedMay 14, 2013
Q | A |
---|---|
Doc fix? | yes |
New docs? | no |
Applies to | 2.3 |
Fixed tickets | #2568 |
Could you please also fix the other things mentioned in#2568 ? And add thepull request format to the pr description? |
@wouterj PR format added. For the |
you're right actually, I never did a good look into that example. I'm 👍 for this, thank you for working on it! |
One thing though: We can/should add a vesionadded directive mentioning the change. Something like: ..versionadded::2.3 The node argument is a ``Crawler`` instance as of Symfony 2.3. In prior versions, it was a ``DOMElement`` instance. |
Do you want me to do it? |
If you can do it: Yes! Otherwise I'll create a PR |
Any news on this topic? |