Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork5.3k
Added documentation for comparison validators#2603
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
danielholmes commentedMay 5, 2013
| Q | A |
|---|---|
| Doc fix? | no |
| New docs? | yes (symfony/symfony#790) |
| Applies to | 2.3+ |
| Fixed tickets | none |
wouterj commentedMay 5, 2013
We did something twice:#2599 But I prefer your one, because you are the creator of those validator :) Thanks for the contribution! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
this option is always the same. Could you please use includes, like I did in my PR? That makes it easier to maintain
danielholmes commentedMay 5, 2013
@wouterj Ahh no I didn't see! Me being the creator of the PR should have no bearing on whether my docs are used. Yours look better in my opinion, so I'm closing this one. Funny that we both decided on the same example (Person and age) |
wouterj commentedMay 5, 2013
ok, your choice.:) If you have any comments on PR, I'm happy to hear that. |