Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork5.2k
Documented dumpFile#2592
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Documented dumpFile#2592
Uh oh!
There was an error while loading.Please reload this page.
Conversation
wouterj commentedMay 3, 2013
| Q | A |
|---|---|
| Doc fix? | no |
| New docs? | yes (symfony/symfony#7753 |
| Applies to | 2.3+ |
| Fixed tickets | #2531 |
| @@ -227,6 +227,20 @@ isAbsolutePath returns true if the given path is absolute, false otherwise:: | |||
| // return false | |||
| $fs->isAbsolutePath('../dir'); | |||
| .. versionadded:: 2.1 | |||
| ``dumpFile`` was new in the Filesystem component in Symfony 2.1, | |||
| previously it could be found in ``CacheFileUtils``. | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
dumpFile is new on master (Symfony 2.3).
"CacheFileUtils" is a class that exists only in a PR of mine but it was never official. Fabien suggested moving the code from there to Filesystem, so I would just remove this versionadded-note.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
fixed
Thanks for opening this PR! It reminds me that I should have documented that :-(. |
don't worry, most of the things I contribute should be done by other people :) |
Awesome feature - thanks for picking up the docs Wouter! |