Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Add assetic DIC tags reference.#2480

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
weaverryan merged 1 commit intosymfony:2.0frompvolok:assetic_tags
May 3, 2013
Merged

Add assetic DIC tags reference.#2480

weaverryan merged 1 commit intosymfony:2.0frompvolok:assetic_tags
May 3, 2013

Conversation

pvolok
Copy link
Contributor

QA
Doc fix?no
New docs?yes
Applies to2.0+
Fixed tickets#2347

The one known issue is that theassetic.asset tag adds the asset to the asset manager, but AsseticBundle throws an exception when any asset has no associated formula. So at the moment this tag seems to be useless. I created an issue(symfony/assetic-bundle#183) in AsseticBundle. Once its filxed, I will add an example.

{
public function process(AssetInterface $asset)
{
// Change $asset or return a new one
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

// ... change $asset or return a new one

@pvolok
Copy link
ContributorAuthor

I think it's ready to be merged. And I'll add more description forassetic.asset oncesymfony/assetic-bundle#183 is resolved.

weaverryan added a commit that referenced this pull requestMay 3, 2013
@weaverryanweaverryan merged commit6690584 intosymfony:2.0May 3, 2013
weaverryan added a commit that referenced this pull requestMay 3, 2013
@weaverryan
Copy link
Member

Hi Pavel!

Nice work with this - it's very nice! If you get more details aboutassetic.asset, just make another PR. I think it's probably better to havesome documentation on these tags rather than nothing: we can improve things from here.

Thanks!

@pvolokpvolok deleted the assetic_tags branchMay 3, 2013 04:47
weaverryan added a commit that referenced this pull requestMay 28, 2013
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

4 participants
@pvolok@weaverryan@stof@wouterj

[8]ページ先頭

©2009-2025 Movatter.jp