Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork5.2k
added documentation for the new Debug component#2479
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
fabpot commentedApr 7, 2013
| Q | A |
|---|---|
| Doc fix? | no |
| New docs? | yes (symfony/symfony#7441) |
| Applies to | 2.3+ |
| Fixed tickets | n/a |
This PR was merged into the master branch.Discussion----------[Debug] added the component (closes#6828,closes#6834,closes#7330)| Q | A| ------------- | ---| Bug fix? | no| New feature? | yes| BC breaks? | no| Deprecations? | yes| Tests pass? | yes| Fixed tickets |#6828,#6834,#7330| License | MIT| Doc PR |symfony/symfony-docs#2479You can use the individual tools, or register them all:```phpuse Symfony\Component\Debug\Debug;Debug::enable();```Changes in Symfony SE:symfony/symfony-standard#523Commits-------f693128 fixed typos1ab1146 [Debug] fixed minor bugsdaa3a3c [Debug] changed composer to accept more versionse455269 [Debug] ensured that the Debug tools can only be registered once946bfb2 [Debug] made the exception handler independant of HttpFoundation2b305c2 added a main Debug class to ease integration2ff0927 [Debug] added the component (closes#6828,closes#6834,closes#7330)
| Debug::enable(); | ||
| The :method:`Symfony\\Component\\Debug\\Debug::enable` method registers an | ||
| error handler and an exception handler. If the Symfony ClassLoader component |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
add some interlinking to the ClassLoader component docs here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
done
you forgot to add this article in the |
| The Debug Component | ||
| =================== | ||
| The Debug Component provides tools to ease debugging PHP code. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
You should add the note saying it is new in 2.3, extracting code from HttpKernel (see how it is done for PropertyAccess)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
fixed
everything should be ok now. |
| The :method:`Symfony\\Component\\Debug\\Debug::enable` method registers an | ||
| error handler and an exception handler. If the :doc:`ClassLoader component | ||
| </components/class_loader>` is available, a special class loader is also |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I prefer to have rules on 1 line:
[...] If the:doc:`ClassLoader component</components/class_loader>` is available,a special [...]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
That's not what we are doing elsewhere. I don't format things by hand but via my text editor.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
It's something I always say on PRs and it's something that's done in all documents as far as I can see.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
ok, I will let you reformat what you think is best.
added documentation for the new Debug component