Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork5.3k
[WCM] Document PhpSessionStorage#2474
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
ghost commentedApr 6, 2013
| Q | A |
|---|---|
| Doc fix? | yes |
| New docs? | yes (symfony/symfony#7571) |
| Applies to | all (or 2.3+) |
| Fixed tickets | na |
stof commentedApr 6, 2013
You should add a note about the fact that the Symfony Session attributes are stored in a single key of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
You need to use double-` for code sections
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Fixed.
ghost commentedApr 6, 2013
@stof - done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Integrating with Legacy Sessions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Fixed.
stanlemon commentedApr 13, 2013
You might consider adding a reference to how someone might use this storage bridge in the full stack framework. That will likely be a very common use case. Very excited about this PR! I'm hoping it'll get merged in before I start my next project. |
ghost commentedApr 13, 2013
OK, Added. |
stanlemon commentedApr 14, 2013
👍 |
This PR was squashed before being merged into the master branch (closes#7571).Discussion----------[2.3] Handle PHP sessions started outside of Symfony| Q | A| ------------- | ---| Bug fix? | no| New feature? | yes| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets || License | MIT| Doc PR |symfony/symfony-docs#2474This PR brings a way to allow Symfony2 to manage a session started outside of Symfony in such a way that quite explicit. It also introduces more robust detection of previously started sessions under PHP 5.3 and supports real session status detection under PHP 5.4Commits-------df99902 [2.3] Handle PHP sessions started outside of Symfony
This PR was squashed before being merged into the master branch (closes #7571).Discussion----------[2.3] Handle PHP sessions started outside of Symfony| Q | A| ------------- | ---| Bug fix? | no| New feature? | yes| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets || License | MIT| Doc PR |symfony/symfony-docs#2474This PR brings a way to allow Symfony2 to manage a session started outside of Symfony in such a way that quite explicit. It also introduces more robust detection of previously started sessions under PHP 5.3 and supports real session status detection under PHP 5.4Commits-------df99902 [2.3] Handle PHP sessions started outside of Symfony
This PR was squashed before being merged into the master branch (closes #7571).Discussion----------[2.3] Handle PHP sessions started outside of Symfony| Q | A| ------------- | ---| Bug fix? | no| New feature? | yes| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets || License | MIT| Doc PR |symfony/symfony-docs#2474This PR brings a way to allow Symfony2 to manage a session started outside of Symfony in such a way that quite explicit. It also introduces more robust detection of previously started sessions under PHP 5.3 and supports real session status detection under PHP 5.4Commits-------df99902 [2.3] Handle PHP sessions started outside of Symfony
ghost commentedApr 18, 2013
This can be merged now. |
stanlemon commentedApr 18, 2013
Something else that might be worth adding is a note about unsetting the custom path for session save paths. Personally, I like that Symfony does this - but because this change is designed specifically for legacy applications migrating over it makes sense to demonstrate how save path's can be cleared out since the legacy app most likely uses a different directly (probably php default). Something as simple as... with a brief explanation perhaps? If you see value in this and want I can try to write something up. |
ghost commentedApr 18, 2013
Sure, if it's set that is.... maybe you can make a PR after this is merged? |
stanlemon commentedApr 18, 2013
Sure thing, I will do that. Thanks! |
ghost commentedApr 20, 2013
@weaverryan - this should be merged now, the feature was merged into Symfony. |
ghost commentedApr 26, 2013
ping@weaverryan - is there a problem merging this? |
weaverryan commentedApr 26, 2013
Hey Drak! Sorry for the delay - I'll get to this soon. I'm working from the oldest PR's to process all the WCM PR's for code that got recently merged. Thanks! |
[WCM] Document PhpSessionStorage
weaverryan commentedApr 27, 2013
Hey Drak! Merged! Only minor changes at sha:73e5095 Thanks! |
This PR was squashed before being merged into the master branch (closes #7571).Discussion----------[2.3] Handle PHP sessions started outside of Symfony| Q | A| ------------- | ---| Bug fix? | no| New feature? | yes| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets || License | MIT| Doc PR |symfony/symfony-docs#2474This PR brings a way to allow Symfony2 to manage a session started outside of Symfony in such a way that quite explicit. It also introduces more robust detection of previously started sessions under PHP 5.3 and supports real session status detection under PHP 5.4Commits-------df99902 [2.3] Handle PHP sessions started outside of Symfony