Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork5.2k
[cookbook][form][dynamic] DataEvent is deprecated in favor of FormEvent#2463
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
| FormEvents::PRE_BIND => 'preBind', | ||
| FormEvents::PRE_SET_DATA => 'preSetData', | ||
| ]; | ||
| ); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
the [] syntax is php 5.4 only, as long as we support 5.3 we should not confuse people with examples that don't work for them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
👍
Hi guys! This is a bit of my fault - I merged in a big change to this document (which included all of these issues) and then made a big fix for them in#2417, which I just merged in. But@dbu I'm happy that you actually read the entryand took time to fix our mistakes (and these were indeed all legitimate issues). The whole entry should be in much better shape now (though I have more changes needed in#2464). Thanks! |
i was actually looking for an existing pull request when i did this but for whatever reason did not see it. anyways, thanks for making the doc better. |
seems this has slipped the corrections applied elsewhere in this file.