Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork5.3k
as my previous PR#2454
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
as my previous PR#2454
Uh oh!
There was an error while loading.Please reload this page.
Conversation
mahmouds commentedApr 3, 2013
@agiuliano something is wrong about the PR the first commit looks good but the second one looks strange and the final file change is wired toohttps://github.com/symfony/symfony-docs/pull/2454/files , can you please check it again ? |
agiuliano commentedApr 3, 2013
Ok, I sent my PR to 2.0 branch. But I've noted there is the same error in master branch: |
mahmouds commentedApr 3, 2013
@agiuliano you sent the PR from your master branch and this is completely wrong you need to close#2456 and open new one from your 2.0 branch |
mahmouds commentedApr 3, 2013
wouterj commentedApr 3, 2013
We leave this PR open. Ryan can cherrypick the commits into the correct branch. The next, you should think of the correct branch beforing starting on something, that makes our life easier. (you can join us at the #symfony-docs freenode IRC channel if you don't understand our branching techniques) |
agiuliano commentedApr 4, 2013
thank you! if you want I can rebranch from 2.0 branch and do another PR.. |
weaverryan commentedApr 10, 2013
Hi Andrea! I can easily cherry-pick in your commits, so that's no problem. But what is the intention of this PR? There are 2 commits, one simply moves a Thanks! |
agiuliano commentedApr 10, 2013
Hi weaverryan, |
mahmouds commentedApr 11, 2013
@weaverryan the main problem is that the setter position in the upload function is before the check for the temp path, The setter then set the temp path with the current upload path and finally the next check in the upload function will delete the new uploaded file. |
fix the other setFile(null)