Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

as my previous PR#2454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed
agiuliano wants to merge2 commits intosymfony:masterfromagiuliano:master
Closed

as my previous PR#2454

agiuliano wants to merge2 commits intosymfony:masterfromagiuliano:master

Conversation

agiuliano
Copy link
Contributor

fix the other setFile(null)

@mahmouds
Copy link
Contributor

@agiuliano something is wrong about the PR the first commit looks good but the second one looks strange and the final file change is wired toohttps://github.com/symfony/symfony-docs/pull/2454/files , can you please check it again ?
also you should send this PR to the 2.0 branch not master.

@agiuliano
Copy link
ContributorAuthor

Ok, I sent my PR to 2.0 branch. But I've noted there is the same error in master branch:
https://github.com/symfony/symfony-docs/blob/master/cookbook/doctrine/file_uploads.rst

@mahmouds
Copy link
Contributor

@agiuliano you sent the PR from your master branch and this is completely wrong you need to close#2456 and open new one from your 2.0 branch

@mahmouds
Copy link
Contributor

@wouterjwouterj mentioned this pull requestApr 3, 2013
@wouterj
Copy link
Member

We leave this PR open. Ryan can cherrypick the commits into the correct branch. The next, you should think of the correct branch beforing starting on something, that makes our life easier. (you can join us at the #symfony-docs freenode IRC channel if you don't understand our branching techniques)

@agiuliano
Copy link
ContributorAuthor

thank you! if you want I can rebranch from 2.0 branch and do another PR..

@weaverryan
Copy link
Member

Hi Andrea!

I can easily cherry-pick in your commits, so that's no problem. But what is the intention of this PR? There are 2 commits, one simply moves asetFile call and the other changessetFile to simply->file. I'm seeing inconsistency between us using the property directly and the setter overall - this document needs a lot of work in general (#2346). What's the intention of this PR?

Thanks!

@agiuliano
Copy link
ContributorAuthor

Hi weaverryan,
the direct access tofile property is because I want only free memory.
If you dosetFile(null) is possible made mistakes in further functions, so is a precaution.
Sorry for the 2 commits, if you want I can do the corrections in only one commit.
Thanks

@mahmouds
Copy link
Contributor

@weaverryan the main problem is that the setter position in the upload function is before the check for the temp path, The setter then set the temp path with the current upload path and finally the next check in the upload function will delete the new uploaded file.
see#2453

@weaverryan
Copy link
Member

Hi guys!

Thanks for the clarification - I didn't see the previous PR. I've patched this into the 2.0 branch at sha:803b3cf and sha:7bf51a8

Thanks!

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

4 participants
@agiuliano@mahmouds@wouterj@weaverryan

[8]ページ先頭

©2009-2025 Movatter.jp