Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

add notes on collection and entity field types#2428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
weaverryan merged 1 commit intosymfony:2.0fromjoelclermont:issue_1566
Apr 4, 2013

Conversation

joelclermont
Copy link
Contributor

QA
Doc fix?yes
New docs?yes
Applies toall
Fixed tickets#1566

I added notes at the top of the collection and entity field types, directing the user to more specific documentation (and the cookbook article) if they are working with collections of Doctrine entities. Hopefully, this will point people in the right direction.

If you are working with a collection of Doctrine entities, it will be helpful
to read the documention for the :doc:`/reference/forms/types/collection`
as well. In addition, there is a complete example in the cookbook article
:doc:`/cookbook/form/form_collections`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I think it's safe to move this under themultiple option, since you'll definitely needmultiple => true for this to be an issue.

@weaverryan
Copy link
Member

I like it! The only improvement that we can't make yet is to link to the addXxx and removeXxx docs that'll be added for#1057. Obviously, we don't need to worry about that now.

@joelclermont
Copy link
ContributorAuthor

Great feedback. Changes made. Removing WIP from title.

.. note::

If you are working with a collection of Doctrine entities, pay special
attention to the ``allow_add``, ``allow_delete`` and ``by_reference`` options.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I prefer to use reference links here:

attention to the `allow_add`_, `allow_delete`_ and `by_reference`_ options.

Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

That makes sense. PR has been updated accordingly.

@wouterj
Copy link
Member

👍

weaverryan added a commit that referenced this pull requestApr 4, 2013
add notes on collection and entity field types
@weaverryanweaverryan merged commit8e196bf intosymfony:2.0Apr 4, 2013
@weaverryan
Copy link
Member

big 👍

Thanks Joel!

@joelclermontjoelclermont deleted the issue_1566 branchApril 4, 2013 12:53
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@joelclermont@weaverryan@wouterj

[8]ページ先頭

©2009-2025 Movatter.jp