Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork5.3k
add notes on collection and entity field types#2428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I think it's safe to move this under themultiple option, since you'll definitely needmultiple => true for this to be an issue.
weaverryan commentedMar 30, 2013
I like it! The only improvement that we can't make yet is to link to the addXxx and removeXxx docs that'll be added for#1057. Obviously, we don't need to worry about that now. |
joelclermont commentedMar 30, 2013
Great feedback. Changes made. Removing WIP from title. |
reference/forms/types/collection.rst Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I prefer to use reference links here:
attention to the `allow_add`_, `allow_delete`_ and `by_reference`_ options.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
That makes sense. PR has been updated accordingly.
wouterj commentedApr 2, 2013
👍 |
…of entities and cookbook article
add notes on collection and entity field types
weaverryan commentedApr 4, 2013
big 👍 Thanks Joel! |
I added notes at the top of the collection and entity field types, directing the user to more specific documentation (and the cookbook article) if they are working with collections of Doctrine entities. Hopefully, this will point people in the right direction.