Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

setValues() instead of setValue()#2420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

@xabbuh
Copy link
Member

QA
Doc fix?yes
New docs?no
Applies toall
Fixed tickets#2412

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I liked the old, short description better.

Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I agree that it sounds better but it doesn't really match the code as you do not real fully qualified names. Any propositions for a better phrasing?

weaverryan added a commit that referenced this pull requestMar 31, 2013
@weaverryan
Copy link
Member

Hey Christian!

I've patched this into the 2.0 branch at sha:f6d0476 and sha:e1be552. I also simplified the English in the description - I think the code below it is the most important: sha:e5814e6

Thanks!

@xabbuhxabbuh deleted the fix-set-values-instead-of-set-value branchMay 2, 2013 10:04
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@xabbuh@weaverryan@Sgoettschkes

[8]ページ先頭

©2009-2025 Movatter.jp