symfony/symfony-docsPublic

NotificationsYou must be signed in to change notification settings
Fork5.2k
Star2.3k

[WIP] [#1134] bootstrap ClassMapGenerator#2411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Closed

cordoval wants to merge1 commit intosymfony:masterfromcordoval:feature/classLoader

Closed

[WIP] [#1134] bootstrap ClassMapGenerator#2411

cordoval wants to merge1 commit intosymfony:masterfromcordoval:feature/classLoader

Conversation

Copy link

Contributor

cordoval commentedMar 30, 2013

#1134,#2407,#3394

[symfony#1134] bootstrap ClassMapGenerator

e713463

stof reviewed

Mar 30, 2013

View reviewed changes

cookbook/class_loader/class_map_generator.rst


		Then, optimize Varnish so that it only parses the Response contents when there
		is at least one ESI tag by checking the ``Surrogate-Control`` header that
		Symfony2 adds automatically:

Copy link

Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

All this has nothing to do with the ClassMapGenerator

Copy link

ContributorAuthor

cordoval commentedMar 30, 2013

WouterJ 10:24:35 AM
cordoval: isn't it better to document the ClassMapGenerator in the components documentation?

cordoval 10:24:45 AM
oh true
missed that 10:24:47 AM
ws there a folder for it? 10:24:52 AM
i never knew 10:24:57 AM

WouterJ 10:25:01 AM
it's components

cordoval 10:25:17 AM
Classloader is a component though
so it can have its own folder? 10:25:23 AM

WouterJ 10:25:26 AM
currently it has only aclass_map.rst file

cordoval 10:25:28 AM
but if no then np
same as cache 10:25:33 AM

WouterJ 10:25:52 AM
you should move that file to a dir calledclass_map and rename it tointroduction.rst
then you need to create an index.rst and map.rst.inc

Copy link

Member

wouterj commentedMar 30, 2013

I forgot to mention that you should also update theredirection_map file in the root to make sure people won't get 404 pages.

Copy link

Member

stof commentedMar 30, 2013

the directy should be namedclass_loader instead ofclass_map though

And could you explain why this article is documenting the HttpCache while you name it ClassMapGenerator ?

Copy link

Member

weaverryan commentedApr 4, 2013

Hi Luis!

I'm going to close this PR for now. I like using the "WIP" pull requests, but I think we should have at least a rough-draft of an entry before opening the PR. But feel free to re-open this after you've filled in the article!

Thanks!