Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork5.2k
[2.1][Security] Fixed typo + some enhancement#2349
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
The 3rd commit ([Security] Fix typo in chain provider entity) is the most important. |
| entity: | ||
| name: entity | ||
| class: SecurityBundle:User | ||
| property: username |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This is wrong. In the previous example, the first level ofentity key is the name of the provider while the second level is the config for theEntityUserProvider.
The config you added here would throw an exception.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I did not test, sorry. But I Copy/paste the same config as bellow. I should fix the in memory user provider ? (IIRC)
About the key |
| property: username | ||
| class: SecurityBundle:User | ||
| property: username | ||
| # same as |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This section MUST be removed. Telling that the previous code is the same than this invalid config is totally wrong. Please don't introduce wrong documentation when your PR says "fixed typos"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Removed. What about memory user provider ?
[2.1][Security] Fixed typo + some enhancement
Hey Grégoire! This is awesome - much more descriptive and accurate. This is actually generated originally from We should fix that as well. Thanks! |
Ok. I will submit a PR. |
Done insymfony/symfony#7528 |
No description provided.