symfony/symfony-docsPublic

NotificationsYou must be signed in to change notification settings
Fork5.3k
Star2.3k

[2.1][Security] Fixed typo + some enhancement#2349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

weaverryan merged 4 commits intosymfony:2.1fromlyrixx:patch-ref-sercu

Mar 30, 2013

Merged

[2.1][Security] Fixed typo + some enhancement#2349

weaverryan merged 4 commits intosymfony:2.1fromlyrixx:patch-ref-sercu

Mar 30, 2013

Conversation

Copy link

Member

lyrixx commentedMar 23, 2013

No description provided.

[Security] Fixed encoder reference

3495929

Copy link

MemberAuthor

lyrixx commentedMar 23, 2013

The 3rd commit ([Security] Fix typo in chain provider entity) is the most important.

stof reviewed

Mar 25, 2013

View reviewed changes

reference/configuration/security.rst Outdated

Copy link

Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This is wrong. In the previous example, the first level ofentity key is the name of the provider while the second level is the config for theEntityUserProvider.
The config you added here would throw an exception.

Copy link

MemberAuthor

lyrixxMar 25, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I did not test, sorry. But I Copy/paste the same config as bellow. I should fix the in memory user provider ? (IIRC)

Copy link

MemberAuthor

lyrixx commentedMar 25, 2013

About the keyname :
I did not test, sorry. But I Copy/paste the same config as bellow. I should fix the in memory user provider ? (IIRC)

stof reviewed

Mar 26, 2013

View reviewed changes

reference/configuration/security.rst Outdated

Copy link

Member

stofMar 26, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This section MUST be removed. Telling that the previous code is the same than this invalid config is totally wrong. Please don't introduce wrong documentation when your PR says "fixed typos"

Copy link

MemberAuthor

lyrixxMar 26, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Removed. What about memory user provider ?

lyrixx added3 commits

March 26, 2013 16:42

[Security] Fix typo in chain provider entity

29c54c3

[Security] Used more explicit name

bbfb24e

[Security] Fixed my_in_memory_provider

a3d5856

weaverryan added a commit that referenced this pull request

Mar 30, 2013

Merge pull request#2349from lyrixx/patch-ref-sercu

bc9febe

[2.1][Security] Fixed typo + some enhancement

weaverryan merged commitbc9febe intosymfony:2.1

Mar 30, 2013

Copy link

Member

weaverryan commentedMar 30, 2013

Hey Grégoire!

This is awesome - much more descriptive and accurate. This is actually generated originally fromconfig:dump-reference where it looks like the example for the in-memory providers is just totally wrong:

https://github.com/symfony/symfony/blob/2.1/src/Symfony/Bundle/SecurityBundle/DependencyInjection/MainConfiguration.php#L303

We should fix that as well.

Thanks!