Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork5.3k
Cleaned up typos in chapter comparing Sf2 and sf1#2324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Fixed paths to example autoloader files (...bundles not ...bundle)
wouterj commentedMar 20, 2013
If I'm correct, this article is already rewritten for 2.1.x? (#1996 ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
You should also change this on the bottom of the page (where all links are placed)
caponica commentedMar 21, 2013
I'll update this to include the reference at the bottom of the page (I missed that one!), the change to the bundle/bundles typo was just because I was there. I didn't realise this block had been updated since I was reading a PDF version of the 2.1 book generated in late 2012. I'll double-check the latest version before making any further pull requests or comments! However, the later versions still talk about vendor/bundles, which I don't think is correct any more... Quote from latest version:
However, as I'm quite new to Symfony namespaces and autoloading (and composer), I'm not clear enough about this to correct it. |
wouterj commentedMar 21, 2013
Yes, this is correct. That should get changed against the 2.1 branch. Moreover, that sentence (and code block) is not relevant in 2.1, as Composer handles the autoloading of every package you get. |
caponica commentedMar 21, 2013
Should I open a ticket to flag this bit for a rewrite? If I was more experienced I'd try it myself but I don't want to confuse people even more! |
wouterj commentedMar 21, 2013
@caponica yes, you can create a issue for that. It's a great issue to fix on the hack day (as it is not that hard to fix). |
Cleaned up typos in chapter comparing Sf2 and sf1
weaverryan commentedMar 30, 2013
Hi Christian! Very nice fixes here! I've merged this in. Thanks guys! |
Fixed name of Symfony Standard Edition and bundle/bundles typos.
Note: however in 2.1.x onwards vendor/bundles is not used any more (and default app/autoload.php doesn't look like this), so might be better to rewrite the autoloader section completely with an Acme example - or explain the new vendor autoloader.