Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork5.2k
Creating parameters page in DI component#2322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
| <service id="mailer" class="Mailer"> | ||
| <argument>%mailer.transport%</argument> | ||
| </service> | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
unneeded empty line here
👍 I like it (expect from those minor fixes), making the book articles shorter is an important thing. |
Should all be sorted now - I should have had a better check of the bits I moved from elsewhere :) |
| .. code-block:: php | ||
| ->addArgument('http://symfony.com/?foo=%%s&bar=%%d'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
thisconfiguration-block needs to be indented one level
Creating parameters page in DI component
…inks to areas where things were removed
Hi Richard! This is an excellent example of carefully, but successfully, moving things into the component documentation. It's very nice! I made a few small tweaks, but the notable one is that if when you removed a section, I put it back, but with just a link to the new spot for that documentation. I think this pretty effectively allows us to continue to make cookbooks readable (and not incomplete) without duplication. Thanks! |
I have moved some of the parameters related content that was spread around the docs into a single page in the DI component section as well as adding a bit more to the page.