Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork5.2k
Added documentation for the Intl component#2312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Contributor
webmozart commentedMar 15, 2013
| Q | A |
|---|---|
| Doc fix? | no |
| New docs? | yes (symfony/symfony#7386) |
| Applies to | 2.3 |
| Fixed tickets | - |
9 tasks
| NumberFormatter | ||
| ~~~~~~~~~~~~~~~ | ||
| Numbers can be formatted with the :phpclass:``NumberFormatter`` class. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
it should be single backticks AFAIK
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thanks, fixed
Does anyone know how to create alternate TOC titles for section headings? For example, I would like the heading to appear as or in the TOC. |
Or maybe it's indeed better to move information about which methods are supported to the API docs and only link there here? |
| * :phpfunction:`intl_get_error_code` | ||
| * :phpfunction:`intl_get_error_message` | ||
| If you don't use Composer but the Symfony ClassLoader component, you need to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
It is maybe nice to add a link to the ClassLoader component here
@bschussek IMO, documenting all methods of the API should be left to the API doc (where you could document with more details what is supported by the stub implementation). The component doc should be about the way to use the component, not about all available methods |
I integrated the suggested changes now. I hope this PR is now complete. |
fabpot added a commit to symfony/symfony that referenced this pull requestApr 18, 2013
This PR was merged into the master branch.Discussion----------[Intl] Refactored Locale component into two new components Icu and Intl| Q | A| ------------- | ---| Bug fix? | yes| New feature? | no| BC breaks? | yes| Deprecations? | yes| Tests pass? | yes| Fixed tickets |#5279| License | MIT| Doc PR |symfony/symfony-docs#2312The Intl component is now a simple drop-in replacement layer for the C intl extension. Install it via Composer and have it available automatically if the intl extension is not available.Additionally, the component ships data from the ICU library which can be accessed through the methods:```phpuse Symfony\Component\Intl\Intl;Intl::getCurrencyBundle()->...Intl::getLanguageBundle()->...Intl::getLocaleBundle()->...Intl::getRegionBundle()->...```If the intl extension is installed, Composer will install the ICU data for the ICU version in the intl extension. If the intl extension is not installed, Composer will use stub ICU data for the latest ICU version (see `Intl::getStubIcuVersion()`).See the [README](/bschussek/symfony/blob/intl/src/Symfony/Component/Intl/README.md) for more information.Todo:- [x] finish the Intl README file- [x] update the Icu README file- [x] update the documentation- [x] make parameter `$locale` optional (default to `\Locale::getDefault()`) in resource bundle methods- [x] remove `(Icu)?Version::compare` calls in the tests- [x] solve deployment problem when trying to install incompatible symfony/icu version listed in composer.lockCreate the following branches in the [Icu component](https://github.com/symfony/Icu):- [x] 1.0.x- [x] 1.1.x- [x] 1.2.xCommits-------9118b4a [Locale] Removed "Stub" prefixes in Intl componentb4cccfd [Intl] Removed "Stub" prefix from stub classes60f31d1 [Intl] Improved inline documentationc2d37e6 [Intl] Improved error messages in the build scripts1249f01 [Intl] Added scripts to test the compatibility of various versions of symfony/icu with the ICU version installed on the system9dbafd7 [Intl] Split update-stubs.php script into two scripts to function with the changed Icu component versioninge2c11cb [Intl] Added a check for the ICU data version to IntlTestHelper to prevent the stub class tests from failing427d24a [Intl] Outsourced bundle reader creation to Icu component0160fd5 [Intl] Moved stub data to Icu component 1.0.xdbca3b7 [Intl] Added empty directory needed for the testsa717ce9 [Intl] Removed ICU version comparisons from the tests5d17de5 [Intl] Fixed version comparisons in the transformation rules470927d [Intl] Improved build scriptsaceb20d [Form] Improved tests to use the IntlTestHelper class3dd75ff [Locale] Improved tests to use the IntlTestHelper class03b78b0 [Validator] Improved tests to use the IntlTestHelper class9d9c389 [Intl] Simplified testsc55c4a2 [Intl] Only the StubNumberFormatterTest requires stub data17a480b [Intl] Added IntlTestHelper class for convenience1dcdcd3 [Locale] Fixed failing testsf6b75b9 [Intl] Changed composer.json to disallow future versions of the Icu component080c880 [Intl] Bumped the stub version to 50.1.2dd2d013 [Intl] Improved the bundle compilation processf47e60a [Intl] Fixed small bugs in the resource bundle transformation467cc93 [Intl] Fixed various problems in the resource compilation process4a5c453 [Intl] Moved the content of the README file to symfony/symfony-docs9899de7 [Intl] Updated the READMEbfec58a [Intl] Fixed flawed PHPDoc21323ba [Intl] Updated the README file209a9cb [Validator] Adapted to latest Intl changesf2a0aec [Form] Adapted to latest Intl changes0f6277f [Locale] Adapted to latest Intl changes2cd1be8 [Intl] Made the $locale parameter optional in the bundle interfacesb9e9cb2 [Intl] Added autoload.php which was ignored by .gitignore838798f [Intl] Removed method IntlTestCase::skipIfInsufficientIcuVersion()dde1d34 [Intl] Changed Intl::getIcuVersion() to return the stub version if the intl extension is not loaded99f6f8a [Form] Fixed failing tests5d0b849 Fixed PHPDocb60866c [Intl] Changed Intl::getStubIcuVersion() to Intl::getIcuStubVersion()b902b6b [Locale] Added default locale01d0ee8 [Validator] Changed component to use the Intl component0c1fe39 [Form] Changed component to use the Intl component5917a2e [Intl] Refactored Locale component into two new components Icu and Intl
fabpot added a commit to symfony/validator that referenced this pull requestApr 18, 2013
This PR was merged into the master branch.Discussion----------[Intl] Refactored Locale component into two new components Icu and Intl| Q | A| ------------- | ---| Bug fix? | yes| New feature? | no| BC breaks? | yes| Deprecations? | yes| Tests pass? | yes| Fixed tickets | #5279| License | MIT| Doc PR |symfony/symfony-docs#2312The Intl component is now a simple drop-in replacement layer for the C intl extension. Install it via Composer and have it available automatically if the intl extension is not available.Additionally, the component ships data from the ICU library which can be accessed through the methods:```phpuse Symfony\Component\Intl\Intl;Intl::getCurrencyBundle()->...Intl::getLanguageBundle()->...Intl::getLocaleBundle()->...Intl::getRegionBundle()->...```If the intl extension is installed, Composer will install the ICU data for the ICU version in the intl extension. If the intl extension is not installed, Composer will use stub ICU data for the latest ICU version (see `Intl::getStubIcuVersion()`).See the [README](/bschussek/symfony/blob/intl/src/Symfony/Component/Intl/README.md) for more information.Todo:- [x] finish the Intl README file- [x] update the Icu README file- [x] update the documentation- [x] make parameter `$locale` optional (default to `\Locale::getDefault()`) in resource bundle methods- [x] remove `(Icu)?Version::compare` calls in the tests- [x] solve deployment problem when trying to install incompatible symfony/icu version listed in composer.lockCreate the following branches in the [Icu component](https://github.com/symfony/Icu):- [x] 1.0.x- [x] 1.1.x- [x] 1.2.xCommits-------9118b4a [Locale] Removed "Stub" prefixes in Intl componentb4cccfd [Intl] Removed "Stub" prefix from stub classes60f31d1 [Intl] Improved inline documentationc2d37e6 [Intl] Improved error messages in the build scripts1249f01 [Intl] Added scripts to test the compatibility of various versions of symfony/icu with the ICU version installed on the system9dbafd7 [Intl] Split update-stubs.php script into two scripts to function with the changed Icu component versioninge2c11cb [Intl] Added a check for the ICU data version to IntlTestHelper to prevent the stub class tests from failing427d24a [Intl] Outsourced bundle reader creation to Icu component0160fd5 [Intl] Moved stub data to Icu component 1.0.xdbca3b7 [Intl] Added empty directory needed for the testsa717ce9 [Intl] Removed ICU version comparisons from the tests5d17de5 [Intl] Fixed version comparisons in the transformation rules470927d [Intl] Improved build scriptsaceb20d [Form] Improved tests to use the IntlTestHelper class3dd75ff [Locale] Improved tests to use the IntlTestHelper class03b78b0 [Validator] Improved tests to use the IntlTestHelper class9d9c389 [Intl] Simplified testsc55c4a2 [Intl] Only the StubNumberFormatterTest requires stub data17a480b [Intl] Added IntlTestHelper class for convenience1dcdcd3 [Locale] Fixed failing testsf6b75b9 [Intl] Changed composer.json to disallow future versions of the Icu component080c880 [Intl] Bumped the stub version to 50.1.2dd2d013 [Intl] Improved the bundle compilation processf47e60a [Intl] Fixed small bugs in the resource bundle transformation467cc93 [Intl] Fixed various problems in the resource compilation process4a5c453 [Intl] Moved the content of the README file to symfony/symfony-docs9899de7 [Intl] Updated the READMEbfec58a [Intl] Fixed flawed PHPDoc21323ba [Intl] Updated the README file209a9cb [Validator] Adapted to latest Intl changesf2a0aec [Form] Adapted to latest Intl changes0f6277f [Locale] Adapted to latest Intl changes2cd1be8 [Intl] Made the $locale parameter optional in the bundle interfacesb9e9cb2 [Intl] Added autoload.php which was ignored by .gitignore838798f [Intl] Removed method IntlTestCase::skipIfInsufficientIcuVersion()dde1d34 [Intl] Changed Intl::getIcuVersion() to return the stub version if the intl extension is not loaded99f6f8a [Form] Fixed failing tests5d0b849 Fixed PHPDocb60866c [Intl] Changed Intl::getStubIcuVersion() to Intl::getIcuStubVersion()b902b6b [Locale] Added default locale01d0ee8 [Validator] Changed component to use the Intl component0c1fe39 [Form] Changed component to use the Intl component5917a2e [Intl] Refactored Locale component into two new components Icu and Intl
fabpot added a commit to symfony/form that referenced this pull requestApr 18, 2013
This PR was merged into the master branch.Discussion----------[Intl] Refactored Locale component into two new components Icu and Intl| Q | A| ------------- | ---| Bug fix? | yes| New feature? | no| BC breaks? | yes| Deprecations? | yes| Tests pass? | yes| Fixed tickets | #5279| License | MIT| Doc PR |symfony/symfony-docs#2312The Intl component is now a simple drop-in replacement layer for the C intl extension. Install it via Composer and have it available automatically if the intl extension is not available.Additionally, the component ships data from the ICU library which can be accessed through the methods:```phpuse Symfony\Component\Intl\Intl;Intl::getCurrencyBundle()->...Intl::getLanguageBundle()->...Intl::getLocaleBundle()->...Intl::getRegionBundle()->...```If the intl extension is installed, Composer will install the ICU data for the ICU version in the intl extension. If the intl extension is not installed, Composer will use stub ICU data for the latest ICU version (see `Intl::getStubIcuVersion()`).See the [README](/bschussek/symfony/blob/intl/src/Symfony/Component/Intl/README.md) for more information.Todo:- [x] finish the Intl README file- [x] update the Icu README file- [x] update the documentation- [x] make parameter `$locale` optional (default to `\Locale::getDefault()`) in resource bundle methods- [x] remove `(Icu)?Version::compare` calls in the tests- [x] solve deployment problem when trying to install incompatible symfony/icu version listed in composer.lockCreate the following branches in the [Icu component](https://github.com/symfony/Icu):- [x] 1.0.x- [x] 1.1.x- [x] 1.2.xCommits-------9118b4a [Locale] Removed "Stub" prefixes in Intl componentb4cccfd [Intl] Removed "Stub" prefix from stub classes60f31d1 [Intl] Improved inline documentationc2d37e6 [Intl] Improved error messages in the build scripts1249f01 [Intl] Added scripts to test the compatibility of various versions of symfony/icu with the ICU version installed on the system9dbafd7 [Intl] Split update-stubs.php script into two scripts to function with the changed Icu component versioninge2c11cb [Intl] Added a check for the ICU data version to IntlTestHelper to prevent the stub class tests from failing427d24a [Intl] Outsourced bundle reader creation to Icu component0160fd5 [Intl] Moved stub data to Icu component 1.0.xdbca3b7 [Intl] Added empty directory needed for the testsa717ce9 [Intl] Removed ICU version comparisons from the tests5d17de5 [Intl] Fixed version comparisons in the transformation rules470927d [Intl] Improved build scriptsaceb20d [Form] Improved tests to use the IntlTestHelper class3dd75ff [Locale] Improved tests to use the IntlTestHelper class03b78b0 [Validator] Improved tests to use the IntlTestHelper class9d9c389 [Intl] Simplified testsc55c4a2 [Intl] Only the StubNumberFormatterTest requires stub data17a480b [Intl] Added IntlTestHelper class for convenience1dcdcd3 [Locale] Fixed failing testsf6b75b9 [Intl] Changed composer.json to disallow future versions of the Icu component080c880 [Intl] Bumped the stub version to 50.1.2dd2d013 [Intl] Improved the bundle compilation processf47e60a [Intl] Fixed small bugs in the resource bundle transformation467cc93 [Intl] Fixed various problems in the resource compilation process4a5c453 [Intl] Moved the content of the README file to symfony/symfony-docs9899de7 [Intl] Updated the READMEbfec58a [Intl] Fixed flawed PHPDoc21323ba [Intl] Updated the README file209a9cb [Validator] Adapted to latest Intl changesf2a0aec [Form] Adapted to latest Intl changes0f6277f [Locale] Adapted to latest Intl changes2cd1be8 [Intl] Made the $locale parameter optional in the bundle interfacesb9e9cb2 [Intl] Added autoload.php which was ignored by .gitignore838798f [Intl] Removed method IntlTestCase::skipIfInsufficientIcuVersion()dde1d34 [Intl] Changed Intl::getIcuVersion() to return the stub version if the intl extension is not loaded99f6f8a [Form] Fixed failing tests5d0b849 Fixed PHPDocb60866c [Intl] Changed Intl::getStubIcuVersion() to Intl::getIcuStubVersion()b902b6b [Locale] Added default locale01d0ee8 [Validator] Changed component to use the Intl component0c1fe39 [Form] Changed component to use the Intl component5917a2e [Intl] Refactored Locale component into two new components Icu and Intl
This can be merged. |
Hi Bernhard! Before I merge this in, I have a few high-level questions.
Thanks! |
1 is fixed insymfony/symfony#7867 |
Thank you for the feedback@weaverryan! As@wouterj mentioned, I fixed (1) in the symfony/symfony repository. (2) is fixed in the commit I just added to this PR. I hope this is better now! :) |
| The replacement layer is limited to the locale "en". If you want to use | ||
| other locales, you should `install the intl extension`_ instead. | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
You are missing a.. versionadded:: 2.3 directive
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
fixed
weaverryan added a commit that referenced this pull requestApr 30, 2013
@bschussek very very nice tweaks - you make things easy! Merged with only minor changes at sha:019bed7 (but let me know if you see something you don't like). Thanks! |
Thank you for the tweaks@weaverryan! :) Being corrected by a native speaker is a great learning opportunity. |
weaverryan added a commit that referenced this pull requestMay 28, 2013
fabpot added a commit to symfony/form that referenced this pull requestNov 25, 2013
This PR was merged into the master branch.Discussion----------[Intl] Refactored Locale component into two new components Icu and Intl| Q | A| ------------- | ---| Bug fix? | yes| New feature? | no| BC breaks? | yes| Deprecations? | yes| Tests pass? | yes| Fixed tickets | #5279| License | MIT| Doc PR |symfony/symfony-docs#2312The Intl component is now a simple drop-in replacement layer for the C intl extension. Install it via Composer and have it available automatically if the intl extension is not available.Additionally, the component ships data from the ICU library which can be accessed through the methods:```phpuse Symfony\Component\Intl\Intl;Intl::getCurrencyBundle()->...Intl::getLanguageBundle()->...Intl::getLocaleBundle()->...Intl::getRegionBundle()->...```If the intl extension is installed, Composer will install the ICU data for the ICU version in the intl extension. If the intl extension is not installed, Composer will use stub ICU data for the latest ICU version (see `Intl::getStubIcuVersion()`).See the [README](/bschussek/symfony/blob/intl/src/Symfony/Component/Intl/README.md) for more information.Todo:- [x] finish the Intl README file- [x] update the Icu README file- [x] update the documentation- [x] make parameter `$locale` optional (default to `\Locale::getDefault()`) in resource bundle methods- [x] remove `(Icu)?Version::compare` calls in the tests- [x] solve deployment problem when trying to install incompatible symfony/icu version listed in composer.lockCreate the following branches in the [Icu component](https://github.com/symfony/Icu):- [x] 1.0.x- [x] 1.1.x- [x] 1.2.xCommits-------9118b4a [Locale] Removed "Stub" prefixes in Intl componentb4cccfd [Intl] Removed "Stub" prefix from stub classes60f31d1 [Intl] Improved inline documentationc2d37e6 [Intl] Improved error messages in the build scripts1249f01 [Intl] Added scripts to test the compatibility of various versions of symfony/icu with the ICU version installed on the system9dbafd7 [Intl] Split update-stubs.php script into two scripts to function with the changed Icu component versioninge2c11cb [Intl] Added a check for the ICU data version to IntlTestHelper to prevent the stub class tests from failing427d24a [Intl] Outsourced bundle reader creation to Icu component0160fd5 [Intl] Moved stub data to Icu component 1.0.xdbca3b7 [Intl] Added empty directory needed for the testsa717ce9 [Intl] Removed ICU version comparisons from the tests5d17de5 [Intl] Fixed version comparisons in the transformation rules470927d [Intl] Improved build scriptsaceb20d [Form] Improved tests to use the IntlTestHelper class3dd75ff [Locale] Improved tests to use the IntlTestHelper class03b78b0 [Validator] Improved tests to use the IntlTestHelper class9d9c389 [Intl] Simplified testsc55c4a2 [Intl] Only the StubNumberFormatterTest requires stub data17a480b [Intl] Added IntlTestHelper class for convenience1dcdcd3 [Locale] Fixed failing testsf6b75b9 [Intl] Changed composer.json to disallow future versions of the Icu component080c880 [Intl] Bumped the stub version to 50.1.2dd2d013 [Intl] Improved the bundle compilation processf47e60a [Intl] Fixed small bugs in the resource bundle transformation467cc93 [Intl] Fixed various problems in the resource compilation process4a5c453 [Intl] Moved the content of the README file to symfony/symfony-docs9899de7 [Intl] Updated the READMEbfec58a [Intl] Fixed flawed PHPDoc21323ba [Intl] Updated the README file209a9cb [Validator] Adapted to latest Intl changesf2a0aec [Form] Adapted to latest Intl changes0f6277f [Locale] Adapted to latest Intl changes2cd1be8 [Intl] Made the $locale parameter optional in the bundle interfacesb9e9cb2 [Intl] Added autoload.php which was ignored by .gitignore838798f [Intl] Removed method IntlTestCase::skipIfInsufficientIcuVersion()dde1d34 [Intl] Changed Intl::getIcuVersion() to return the stub version if the intl extension is not loaded99f6f8a [Form] Fixed failing tests5d0b849 Fixed PHPDocb60866c [Intl] Changed Intl::getStubIcuVersion() to Intl::getIcuStubVersion()b902b6b [Locale] Added default locale01d0ee8 [Validator] Changed component to use the Intl component0c1fe39 [Form] Changed component to use the Intl component5917a2e [Intl] Refactored Locale component into two new components Icu and Intl
fabpot added a commit to symfony/form that referenced this pull requestMay 23, 2014
This PR was merged into the master branch.Discussion----------[Intl] Refactored Locale component into two new components Icu and Intl| Q | A| ------------- | ---| Bug fix? | yes| New feature? | no| BC breaks? | yes| Deprecations? | yes| Tests pass? | yes| Fixed tickets | #5279| License | MIT| Doc PR |symfony/symfony-docs#2312The Intl component is now a simple drop-in replacement layer for the C intl extension. Install it via Composer and have it available automatically if the intl extension is not available.Additionally, the component ships data from the ICU library which can be accessed through the methods:```phpuse Symfony\Component\Intl\Intl;Intl::getCurrencyBundle()->...Intl::getLanguageBundle()->...Intl::getLocaleBundle()->...Intl::getRegionBundle()->...```If the intl extension is installed, Composer will install the ICU data for the ICU version in the intl extension. If the intl extension is not installed, Composer will use stub ICU data for the latest ICU version (see `Intl::getStubIcuVersion()`).See the [README](/bschussek/symfony/blob/intl/src/Symfony/Component/Intl/README.md) for more information.Todo:- [x] finish the Intl README file- [x] update the Icu README file- [x] update the documentation- [x] make parameter `$locale` optional (default to `\Locale::getDefault()`) in resource bundle methods- [x] remove `(Icu)?Version::compare` calls in the tests- [x] solve deployment problem when trying to install incompatible symfony/icu version listed in composer.lockCreate the following branches in the [Icu component](https://github.com/symfony/Icu):- [x] 1.0.x- [x] 1.1.x- [x] 1.2.xCommits-------9118b4a [Locale] Removed "Stub" prefixes in Intl componentb4cccfd [Intl] Removed "Stub" prefix from stub classes60f31d1 [Intl] Improved inline documentationc2d37e6 [Intl] Improved error messages in the build scripts1249f01 [Intl] Added scripts to test the compatibility of various versions of symfony/icu with the ICU version installed on the system9dbafd7 [Intl] Split update-stubs.php script into two scripts to function with the changed Icu component versioninge2c11cb [Intl] Added a check for the ICU data version to IntlTestHelper to prevent the stub class tests from failing427d24a [Intl] Outsourced bundle reader creation to Icu component0160fd5 [Intl] Moved stub data to Icu component 1.0.xdbca3b7 [Intl] Added empty directory needed for the testsa717ce9 [Intl] Removed ICU version comparisons from the tests5d17de5 [Intl] Fixed version comparisons in the transformation rules470927d [Intl] Improved build scriptsaceb20d [Form] Improved tests to use the IntlTestHelper class3dd75ff [Locale] Improved tests to use the IntlTestHelper class03b78b0 [Validator] Improved tests to use the IntlTestHelper class9d9c389 [Intl] Simplified testsc55c4a2 [Intl] Only the StubNumberFormatterTest requires stub data17a480b [Intl] Added IntlTestHelper class for convenience1dcdcd3 [Locale] Fixed failing testsf6b75b9 [Intl] Changed composer.json to disallow future versions of the Icu component080c880 [Intl] Bumped the stub version to 50.1.2dd2d013 [Intl] Improved the bundle compilation processf47e60a [Intl] Fixed small bugs in the resource bundle transformation467cc93 [Intl] Fixed various problems in the resource compilation process4a5c453 [Intl] Moved the content of the README file to symfony/symfony-docs9899de7 [Intl] Updated the READMEbfec58a [Intl] Fixed flawed PHPDoc21323ba [Intl] Updated the README file209a9cb [Validator] Adapted to latest Intl changesf2a0aec [Form] Adapted to latest Intl changes0f6277f [Locale] Adapted to latest Intl changes2cd1be8 [Intl] Made the $locale parameter optional in the bundle interfacesb9e9cb2 [Intl] Added autoload.php which was ignored by .gitignore838798f [Intl] Removed method IntlTestCase::skipIfInsufficientIcuVersion()dde1d34 [Intl] Changed Intl::getIcuVersion() to return the stub version if the intl extension is not loaded99f6f8a [Form] Fixed failing tests5d0b849 Fixed PHPDocb60866c [Intl] Changed Intl::getStubIcuVersion() to Intl::getIcuStubVersion()b902b6b [Locale] Added default locale01d0ee8 [Validator] Changed component to use the Intl component0c1fe39 [Form] Changed component to use the Intl component5917a2e [Intl] Refactored Locale component into two new components Icu and Intl
fago pushed a commit to fago/Validator that referenced this pull requestApr 18, 2015
This PR was merged into the master branch.Discussion----------[Intl] Refactored Locale component into two new components Icu and Intl| Q | A| ------------- | ---| Bug fix? | yes| New feature? | no| BC breaks? | yes| Deprecations? | yes| Tests pass? | yes| Fixed tickets | #5279| License | MIT| Doc PR |symfony/symfony-docs#2312The Intl component is now a simple drop-in replacement layer for the C intl extension. Install it via Composer and have it available automatically if the intl extension is not available.Additionally, the component ships data from the ICU library which can be accessed through the methods:```phpuse Symfony\Component\Intl\Intl;Intl::getCurrencyBundle()->...Intl::getLanguageBundle()->...Intl::getLocaleBundle()->...Intl::getRegionBundle()->...```If the intl extension is installed, Composer will install the ICU data for the ICU version in the intl extension. If the intl extension is not installed, Composer will use stub ICU data for the latest ICU version (see `Intl::getStubIcuVersion()`).See the [README](/bschussek/symfony/blob/intl/src/Symfony/Component/Intl/README.md) for more information.Todo:- [x] finish the Intl README file- [x] update the Icu README file- [x] update the documentation- [x] make parameter `$locale` optional (default to `\Locale::getDefault()`) in resource bundle methods- [x] remove `(Icu)?Version::compare` calls in the tests- [x] solve deployment problem when trying to install incompatible symfony/icu version listed in composer.lockCreate the following branches in the [Icu component](https://github.com/symfony/Icu):- [x] 1.0.x- [x] 1.1.x- [x] 1.2.xCommits-------9118b4a [Locale] Removed "Stub" prefixes in Intl componentb4cccfd [Intl] Removed "Stub" prefix from stub classes60f31d1 [Intl] Improved inline documentationc2d37e6 [Intl] Improved error messages in the build scripts1249f01 [Intl] Added scripts to test the compatibility of various versions of symfony/icu with the ICU version installed on the system9dbafd7 [Intl] Split update-stubs.php script into two scripts to function with the changed Icu component versioninge2c11cb [Intl] Added a check for the ICU data version to IntlTestHelper to prevent the stub class tests from failing427d24a [Intl] Outsourced bundle reader creation to Icu component0160fd5 [Intl] Moved stub data to Icu component 1.0.xdbca3b7 [Intl] Added empty directory needed for the testsa717ce9 [Intl] Removed ICU version comparisons from the tests5d17de5 [Intl] Fixed version comparisons in the transformation rules470927d [Intl] Improved build scriptsaceb20d [Form] Improved tests to use the IntlTestHelper class3dd75ff [Locale] Improved tests to use the IntlTestHelper class03b78b0 [Validator] Improved tests to use the IntlTestHelper class9d9c389 [Intl] Simplified testsc55c4a2 [Intl] Only the StubNumberFormatterTest requires stub data17a480b [Intl] Added IntlTestHelper class for convenience1dcdcd3 [Locale] Fixed failing testsf6b75b9 [Intl] Changed composer.json to disallow future versions of the Icu component080c880 [Intl] Bumped the stub version to 50.1.2dd2d013 [Intl] Improved the bundle compilation processf47e60a [Intl] Fixed small bugs in the resource bundle transformation467cc93 [Intl] Fixed various problems in the resource compilation process4a5c453 [Intl] Moved the content of the README file to symfony/symfony-docs9899de7 [Intl] Updated the READMEbfec58a [Intl] Fixed flawed PHPDoc21323ba [Intl] Updated the README file209a9cb [Validator] Adapted to latest Intl changesf2a0aec [Form] Adapted to latest Intl changes0f6277f [Locale] Adapted to latest Intl changes2cd1be8 [Intl] Made the $locale parameter optional in the bundle interfacesb9e9cb2 [Intl] Added autoload.php which was ignored by .gitignore838798f [Intl] Removed method IntlTestCase::skipIfInsufficientIcuVersion()dde1d34 [Intl] Changed Intl::getIcuVersion() to return the stub version if the intl extension is not loaded99f6f8a [Form] Fixed failing tests5d0b849 Fixed PHPDocb60866c [Intl] Changed Intl::getStubIcuVersion() to Intl::getIcuStubVersion()b902b6b [Locale] Added default locale01d0ee8 [Validator] Changed component to use the Intl component0c1fe39 [Form] Changed component to use the Intl component5917a2e [Intl] Refactored Locale component into two new components Icu and Intl
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.