Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[#2290] Single command apps with arguments#2292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
weaverryan merged 1 commit intosymfony:2.0fromeugene-dounar:2.0
Mar 21, 2013
Merged

[#2290] Single command apps with arguments#2292

weaverryan merged 1 commit intosymfony:2.0fromeugene-dounar:2.0
Mar 21, 2013

Conversation

eugene-dounar
Copy link

QA
Doc fix?yes
New docs?no
Applies toall
Fixed tickets#2290

| Q             | A| ------------- | ---| Doc fix?      | yes| New docs?     | no| Applies to    | all| Fixed tickets |#2290
.. note::

If your command accepts one or more arguments, you may also want to override
getDefinition() method.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

You should indent these 2 lines with 4 spaces

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

you should changegetDefinition() to a method link to the API docs as described here:http://symfony.com/doc/current/contributing/documentation/format.html#adding-links

@wouterj
Copy link
Member

Offtopic: A small GIT tip from me: Create a new branch (git checkout -b YOUR_NEW_BRANCH) for each PR, this avoids conflicts.

weaverryan added a commit that referenced this pull requestMar 21, 2013
[#2290] Single command apps with arguments
@weaverryanweaverryan merged commitc06454d intosymfony:2.0Mar 21, 2013
weaverryan added a commit that referenced this pull requestMar 21, 2013
@weaverryan
Copy link
Member

Hi Eugene!

I've merged this in and made a few tweaks that@wouterj mentioned. I verified the issue, so it's an excellent fix. To make it even more obvious, I expanded the code example in sha:0b7d8f4

If you see any tweaks needed, let me know!

Thanks!

@eugene-dounareugene-dounar deleted the 2.0 branchMarch 22, 2013 12:16
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@eugene-dounar@wouterj@weaverryan
[8]ページ先頭
©2009-2025 Movatter.jp