Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork5.3k
[HttpClient] Improve the wording about asynchronous requests#21650
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:6.4
Are you sure you want to change the base?
Changes fromall commits
File filter
Filter by extension
Conversations
Uh oh!
There was an error while loading.Please reload this page.
Jump to
Uh oh!
There was an error while loading.Please reload this page.
Diff view
Diff view
- Loading branch information
Uh oh!
There was an error while loading.Please reload this page.
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -375,21 +375,22 @@ HTTP requests:: | ||||||
| ], | ||||||
| ]); | ||||||
| Symfony's HTTP client is asynchronous by default. When you call ``request()``, | ||||||
| the HTTP request starts immediately, but the method returns without waiting for | ||||||
Member There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others.Learn more. Suggested change
MemberAuthor There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others.Learn more. But if we say "might start" ... then we need to explain when it starts and when it doesn't. Please, share some details about this. Thanks. Member There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others.Learn more. I don't know, curl does. We don't care here, that's the whole point | ||||||
| a response. Your code only blocks when you actually need the response data:: | ||||||
| //the request starts, but execution continues without waiting | ||||||
Member There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others.Learn more. Suggested change
| ||||||
| $response = $client->request('GET', 'http://releases.ubuntu.com/18.04.2/ubuntu-18.04.2-desktop-amd64.iso'); | ||||||
| //this blocks untilthe response headersare received | ||||||
| $contentType = $response->getHeaders()['content-type'][0]; | ||||||
| // this blocks until the full response body is received | ||||||
| $content = $response->getContent(); | ||||||
| The HTTP client also supports :ref:`concurrent requests <http-client-concurrent-requests>` | ||||||
| to make multiple HTTP requests in parallel, and :ref:`streaming responses <http-client-streaming-responses>` | ||||||
| to process response data in chunks for fully asynchronous applications. | ||||||
| Authentication | ||||||
| ~~~~~~~~~~~~~~ | ||||||
| @@ -1327,6 +1328,8 @@ the error-handling code (by calling ``$response->getStatusCode()``), you will | ||||||
| opt-out from these fallback mechanisms as the destructor won't have anything | ||||||
| remaining to do. | ||||||
| .. _http-client-concurrent-requests: | ||||||
| Concurrent Requests | ||||||
| ------------------- | ||||||