Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork5.3k
[HttpClient] Improve the wording about asynchronous requests#21650
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:6.4
Are you sure you want to change the base?
Conversation
| Responses are always asynchronous, so that the call to the method returns | ||
| immediately instead of waiting to receive the response:: | ||
| Symfony's HTTP client is asynchronous by default. When you call ``request()``, | ||
| the HTTP request starts immediately, but the method returns without waiting for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
| the HTTP requeststarts immediately, but the method returns without waiting for | |
| the HTTP requestmight start immediately, but the method returns without waiting for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
But if we say "might start" ... then we need to explain when it starts and when it doesn't. Please, share some details about this. Thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I don't know, curl does. We don't care here, that's the whole point
| a response. Your code only blocks when you actually need the response data:: | ||
| //code execution continues immediately; it doesn't wait to receive the response | ||
| //the request starts, but execution continues without waiting |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
| // the requeststarts, but execution continues without waiting | |
| // the requestmight start, but execution continues without waiting |
A minor change to be more precise about the actual behavior of the HTTP client.