Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[Serializer] Remove unhelpful exposed "serializer alternative"#21435

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
smnandre wants to merge2 commits intosymfony:7.3
base:7.3
Choose a base branch
Loading
fromsmnandre:patch-16

Conversation

smnandre
Copy link
Member

Removed mention of JMS serializer as an alternative to Symfony Serializer.

It was pushed at the bottom of page in#7043

Reintroduced in#17783 during the big merge of the serializer docs (i guess because new structure had no more a natural good place in the end of the page)


To me, it does not feel necessary, and I'm betting create more confusion in readers mind that really helps anyone..

But my main point will be "why is this not done on other packages doc pages?" ... if we need to promote alternative, I can think of a few other Symfony packages where that kind of mention could be legit...

Well just a minor thing passing by :)

So I suggest we simply remove this mention.

Removed mention of JMS serializer as an alternative to Symfony Serializer.It was pushed at the bottom of page insymfony#7043Reintroduced insymfony#17783 during the big merge of the serializer docs (i guess because new structure had no more a natural good place in the end of the page)---To me, it does not feel necessary, and I'm betting create more confusion in readers mind that really helps anyone..But my main point will be "why is this not done on other packages doc pages?" ... if we need to promote alternative, I can think of a few other Symfony packages where that kind of mention could be legit...Well just a minor thing passing by :)So I suggest we simply remove this mention.
Removed link to JMS serializer from serializer.rst
@wouterj
Copy link
Member

I actually intentionally placed the note at the top when rewriting the serializer documentation. See#17783 (comment) for a bit of the reasoning. I think this still holds true.

Can you elaborate a bit on what confusion you think this will cause readers? Maybe we can reword it slightly?

@smnandre
Copy link
MemberAuthor

@wouterj I indeed missed that discussion, thanks for the link! 😃

I am still not entirely convinced, and will share my reasoning.

But this isall but an important topic, so I will not mind if you skip it :)


If someone is reading theSerializer page on symfony.com there are two cases: eithersymfony/serializer is already in their composer.json or it is not :)

If it is already installed, readers usually come for usage docs (and in Google the link is titledHow to Use the Serializer). They will probably ignore the block but, if not, the "popular" wording feelsunusual for Symfony docs, which makes it stand out and can then confuse.

If not, the reader's goal is probably either to discover the component or toinstall it because a CTO or tool requires it. In both situations, pointing toanother library at the end of the install steps adds little context and mostly risks creating doubts or mistakes.

Finally, one could askwhy this library (other serializers may be more "popular" today) and whyonly this one (components like HttpClient, Filesystem, or Uid do not suggest alternatives in their docs).

Well... just me overthinking details again 😇

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@smnandre@wouterj@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp