Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork5.3k
Add guideline that changing default values is a BC break#21371
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:6.4
Are you sure you want to change the base?
Add guideline that changing default values is a BC break#21371
Uh oh!
There was an error while loading.Please reload this page.
Conversation
| | Change default value of an argument| No:ref:`[12]<note-12>`| | ||
| +-----------------------------------------------+-----------------------------+ | ||
| | Remove default value of an argument| No:ref:`[13]<note-13>`| | ||
| +-----------------------------------------------+-----------------------------+ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
The BC promise consist of 2 main sections:
- The first part is "Using Symfony Code", here we explain "if you use an interface/class from Symfony and do this, you can expect your code to keep working"
- The second part is "Working on Symfony Code", where we explain which changes we and our contributors are allowed to make to Symfony interfaces/classes.
Given this table is part of the first section, we should either revert both of them or change the first to "Yes" and revert the last one.
If you change the default value when implementing an interface, no change in the interface will break your code. So it's OK to change the default value.
And removing a default value while the interface has a default value is not possible in PHP.
| Remove argument No:ref:`[3]<note-3>` | ||
| Add default value to an argument No:ref:`[7]<note-7>`:ref:`[8]<note-8>` | ||
| Remove default value of an argument No | ||
| Remove default value of an argument No:ref:`[13]<note-13>` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Is there a reason not to add "Change default value of an argument No" here and for protected methods below?
No description provided.