Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Update security.rst related to stateless JS csrf#21293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
94noni wants to merge1 commit intosymfony:7.3
base:7.3
Choose a base branch
Loading
from94noni:patch-15

Conversation

94noni
Copy link
Contributor

No description provided.

@carsonbotcarsonbot changed the titleUpdate security.rst related to stateless JS csrf Update security.rst related to stateless JS csrfAug 18, 2025
Comment on lines +1024 to +1026
the ``data-controller`` part is related to the usage of
https://symfony.com/doc/current/security/csrf.html#generating-csrf-token-using-javascript
It can be removed if you use statefull session storage, not stateless.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I don't think it's useful to hint this can be removed. But it's always good to explain why the attribute is here:

Suggested change
the ``data-controller`` part is related to the usage of
https://symfony.com/doc/current/security/csrf.html#generating-csrf-token-using-javascript
It can be removed if you use statefull session storage, not stateless.
The ``data-controller`` attribute is needed for [internal link here, not absolute URL].

Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

yes I agree, I can rework it if its accepted
my point was mostly to document why this data attribute is here in the doc (and also on console maker processes)

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@nicolas-grekasnicolas-grekasnicolas-grekas left review comments

Assignees
No one assigned
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@94noni@nicolas-grekas@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp