Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork5.2k
[HtmlSanitizer] Fix method names#21216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:6.4
Are you sure you want to change the base?
Conversation
Changed incorrect method names from `allowed*` to `allow*`:- allowedLinkSchemes() → allowLinkSchemes()- allowedLinkHosts() → allowLinkHosts()- allowedMediaSchemes() → allowMediaSchemes()- allowedMediaHosts() → allowMediaHosts()These are the correct method names used in the HtmlSanitizerConfig class.Fixes#21211
| ->forceHttpsUrls(true) | ||
| // specifies the allowed URL schemes. If the URL has a different scheme, the | ||
| // attribute will be dropped | ||
| ->allowedLinkSchemes(['http', 'https', 'mailto']) | ||
| ->allowLinkSchemes(['http', 'https', 'mailto']) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
For the DI configuration this is not the correct change, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
indeed. That's why the CI fails
| // specifies the allowed hosts, the attribute will be dropped if the | ||
| // URL contains a different host. Subdomains are allowed: e.g. the following | ||
| // config would also allow 'www.symfony.com', 'live.symfony.com', etc. | ||
| ->allowedLinkHosts(['symfony.com']) | ||
| ->allowLinkHosts(['symfony.com']) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
same here
Changed incorrect method names from
allowed*toallow*:These are the correct method names used in the HtmlSanitizerConfig class.
Fixes#21211