Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork5.2k
Clarify Lazy Services usage withfinal
&readonly
classes#21065
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
kiler129 wants to merge1 commit intosymfony:7.3Choose a base branch fromkiler129:patch-4
base:7.3
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
@@ -23,8 +23,8 @@ until you interact with the proxy in some way. | |||
.. warning:: | |||
Lazy services do not support `final`_ or ``readonly`` classes, but you can use | |||
`Interface Proxifying`_ to work around this limitation. | |||
Lazy services support for `final`_ or ``readonly`` classes was introduced in Symfony 7.3, and |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This is not a warning anymore, make let's move this to a versionadded 7.3 directive?
final
&readonly
classesSign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Since Symfony 7.3 lazy services support
final
andreadonly
objects:This works sincePHP 8.4 allows for native lazy ghosts that don't need to extend the class:
The support for this feature was introduced insymfony/symfony@ed695a6 (preciselyhere). However, documentation still points users to use Interface Proxifying, regardless of the frameworks or PHP version.