Movatterモバイル変換

Skip to content

symfony/symfony-docsPublic

NotificationsYou must be signed in to change notification settings
Fork5.2k
Star2.3k

[Security] Fix type in`upgradePassword`#20990

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

javiereguiluz merged 1 commit intosymfony:6.4fromSynxgz:patch-1

May 23, 2025

Merged

[Security] Fix type in`upgradePassword`#20990

javiereguiluz merged 1 commit intosymfony:6.4fromSynxgz:patch-1

May 23, 2025

Conversation

Synxgz

Copy link

Contributor

Synxgz commentedMay 23, 2025•
edited
Loading

Fix the wrong type for the methodupgradePassword according toPasswordUpgraderInterface.

It is wrong since the 6.0, the signature has changed fromPasswordAuthenticatedUserInterface|UserInterface toPasswordAuthenticatedUserInterface inPasswordUpgraderInterface.

Commit:symfony/symfony@30e2c00#diff-b31195679b81d7a86cf868774ef3bf74a79e8e059250db399531b989b4919bdeL17

Prevents PHP Error :

Compile Error: Declaration of App\Services\Security\EmailUserProvider::upgradePassword(Symfony\Component\Security\Core\User\UserInterface $user, string $newHashedPassword): void must be compatible with Symfony\Component\Security\Core\User\PasswordUpgraderInterface::upgradePassword(Symfony\Component\Security\Core\User\PasswordAuthenticatedUserInterface $user, string $newHashedPassword): void

@carsonbot

carsonbot added Status: Needs Review Security labels

@carsonbot

carsonbot added this to the6.4 milestone

xabbuh

xabbuh reviewed

View reviewed changes

security/passwords.rstShow resolvedHide resolved

@javiereguiluz

javiereguiluz added Status: Reviewed and removed Status: Needs Review labels

@Synxgz

@javiereguiluz

[Security] Fix type inupgradePassword

6a90896

@javiereguiluz

javiereguiluz force-pushed thepatch-1 branch froma963e9c to6a90896Compare

May 23, 2025 12:57

@javiereguiluz

Copy link

Member

javiereguiluz commentedMay 23, 2025

Good catch Romain! Thanks ... and congrats on your first Symfony Docs contribution 🎉

@javiereguiluz

javiereguiluz merged commit6e01dc1 intosymfony:6.4

3 checks passed

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Labels

Security Status: Reviewed

4 participants

@Synxgz

@javiereguiluz

@xabbuh

@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp