Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork5.2k
[Security] removeplaintext password hasher usage#20986
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation
| memory_cost="10" | ||
| /> | ||
| </config> | ||
| <when env="test"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I'm not super confident on these xml/php config changes - please review.
| memory_cost="10" | ||
| /> | ||
| </config> | ||
| <when env="test"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
should be<srv:when> as this code snippet defines the SecurityBundle XML namespace as the default namespace and uses thesrv alias for the XML namespace of the DI component
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
hmm, actually, this XML code snippet is already a mess, as it mixes cases, sometimes using asecurity alias (not registered on the top-level element) for nodes of the SecurityBundle config
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
What should we do here? Can this snippet be fixed easily? Otherwise, we could just remove it. Symfony plans to remove XML config support "soon", so this is not important. Thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I'd vote to remove
705251b to1ea48c7Compare53470f9 intosymfony:6.4Uh oh!
There was an error while loading.Please reload this page.
Merged! We merged it in 6.4 and up. We also removed the wrong XML config while merging. Thanks Kevin! |
I think we shouldn't promote using the plaintext hasher at all.
Context:
testenvironment recipes#1024