Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[Translation] Clarifying LocaleSwitcher's behavior#20981

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
javiereguiluz merged 1 commit intosymfony:6.4fromktherage:patch-3
May 21, 2025

Conversation

ktherage
Copy link
Contributor

No description provided.

Copy link
Member

@welcoMatticwelcoMattic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

If this note is valid for 6.4, can you target 6.4 branch please?

Comment on lines +1109 to +1118
The LocaleSwitcher will apply the locale at a request level
this means that it will be available only for that request. A
redirect, for example, will cancel the LocaleSwitcher's effect.
For a permanent locale switch between requests see https://symfony.com/doc/current/session.html#making-the-locale-sticky-during-a-user-s-session.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Suggested change
The LocaleSwitcher will apply the locale at a request level
this means that it will be available only for that request.A
redirect, for example, will cancel the LocaleSwitcher's effect.
For a permanent locale switch between requests see https://symfony.com/doc/current/session.html#making-the-locale-sticky-during-a-user-s-session.
The LocaleSwitcher will apply the locale at a request level.
This means that it will be available only for that request.
Aredirect, for example, will cancel the LocaleSwitcher's effect.
For a permanent locale switch between requests see https://symfony.com/doc/current/session.html#making-the-locale-sticky-during-a-user-s-session.

About the URL, can you follow the RST format for links please? (seehttps://github.com/symfony/symfony-docs/pull/20981/files#diff-9ee808b36fb9f3ce98827e47f96d7bf1d53c039fed97fb8364087cd629be779cR1095)

@javiereguiluzjaviereguiluz added this to the6.4 milestoneMay 21, 2025
@carsonbotcarsonbot changed the titleClarifying LocaleSwitcher's behavior[Translation] Clarifying LocaleSwitcher's behaviorMay 21, 2025
@javiereguiluzjaviereguiluz changed the base branch from7.2 to6.4May 21, 2025 08:03
@javiereguiluzjaviereguiluz merged commit99b3c4f intosymfony:6.4May 21, 2025
3 checks passed
@javiereguiluz
Copy link
Member

Thanks Kévin!

We merged this in 6.4 and did the changes proposed by Mathieu (and some other rewords) while merging.

welcoMattic reacted with thumbs up emojiktherage reacted with heart emoji

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@welcoMatticwelcoMatticwelcoMattic requested changes

@xabbuhxabbuhAwaiting requested review from xabbuh

Assignees
No one assigned
Projects
None yet
Milestone
6.4
Development

Successfully merging this pull request may close these issues.

4 participants
@ktherage@javiereguiluz@welcoMattic@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp