Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork5.2k
[Twig] [TwigBundle] Describe the new behaviour of twig.cache config#20951
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Signed-off-by: Quentin Devos <4972091+Okhoshi@users.noreply.github.com>
f6e6a8c
intosymfony:7.3Uh oh!
There was an error while loading.Please reload this page.
Thanks Quentin for this contribution! I did some minor rewords while merging, but I left your core contribution intact. I find the new docs a bit confusing so I'masking something to you. Is the following current explanation:
Equivalent to this simplified version?
I mean:
Maybe I'm missing something here. |
@javiereguiluz It's indeed a bit confusing, because the setup is a bit more convoluted, but for the sake of simplicity, not all the details are described in the doc. There's actually a slight difference when the cache is set to Hence why the distinction, even if you are actually right with the simplified version. Happy to discuss any improvements we can make on the doc for this 👍 |
Thanks for the detailed explanation 🙏 I think you are right that it's better to not mention all these internal details in the docs. Also, let's wait until Symfony uses |
Update the description of the
twig.cache
config to follow the changes implemented insymfony/symfony#54384.Fixes#20948
cc@alexandre-daubois