Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork5.2k
[Console] Update some contents of the Tree helper#20942
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
| $node = TreeNode::fromValues([ | ||
| 'Command', | ||
| 'Controller' => [ | ||
| 'DefaultController.php', | ||
| ], | ||
| 'Kernel.php', | ||
| ]); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
TreeNode from multidimensional array should be documented I think.
(I build this array first, and then use it in TreeHelper)
components/console/helpers/tree.rst Outdated
| @@ -133,7 +144,11 @@ output of the tree:: | |||
| $tree = TreeHelper::createTree($io, $node, [], TreeStyle::compact()); | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This code block must be removed, right ?
components/console/helpers/tree.rst Outdated
| @@ -150,7 +165,11 @@ output of the tree:: | |||
| └── templates | |||
| └── base.html.twig | |||
| ``TreeHelper::createTree($io, $node, [], TreeStyle::box())`` (`details`_) | |||
| **Box**: | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
| **Box**: | |
| **Box**:: |
Without:
components/console/helpers/tree.rst Outdated
| @@ -235,7 +270,11 @@ output of the tree:: | |||
| . templates | |||
| . base.html.twig | |||
| ``TreeHelper::createTree($io, $node, [], TreeStyle::rounded())`` (`details`_) | |||
| **Rounded**: | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
| **Rounded**: | |
| **Rounded**:: |
What a great review! Thanks a lot Antoine. I did all the changes and fixes that you suggested. Thanks! |
components/console/helpers/tree.rst Outdated
| You can also build part of the tree from an array and then add other nodes:: | ||
| $node = TreeNode::fromValues($array) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
| $node = TreeNode::fromValues($array) | |
| $node = TreeNode::fromValues($array); |
This updates the Tree helper explanation about custom styles to match the same structure as in the Table helper page (see#20941). It also adds a better example of how to create trees programmatically.