symfony/symfony-docsPublic

NotificationsYou must be signed in to change notification settings
Fork5.2k
Star2.3k

[Mailer][Mime] Refactor S/MIME encryption handling in`SMimeEncryptionListener`#20935

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

javiereguiluz merged 1 commit intosymfony:7.3fromalamirault:feature/20827-smime-encrypter

May 8, 2025

Merged

[Mailer][Mime] Refactor S/MIME encryption handling in`SMimeEncryptionListener`#20935

javiereguiluz merged 1 commit intosymfony:7.3fromalamirault:feature/20827-smime-encrypter

May 8, 2025

Conversation

Copy link

Contributor

alamirault commentedMay 4, 2025

Fix#20827

Having aSmimeCertificateRepositoryInterface implementation is a good thing I think.
I don't really how to introduce it.

[Mailer][Mime] Refactor S/MIME encryption handling in SMimeEncryption…

c6a7fe6

…Listener

carsonbot added Status: Needs Review Mailer Mime labels

May 4, 2025

carsonbot added this to the7.3 milestone

May 4, 2025

Copy link

Member

javiereguiluz commentedMay 5, 2025

I don't know much about this 🙏 but the previous example looked pretty convenient.

Is it really a bad practice? If it's not, maybe we can show both alternatives?

javiereguiluz added the Waiting feedback label

May 5, 2025

Copy link

ContributorAuthor

alamirault commentedMay 6, 2025

I thinks it's ok, but I don't really know others possible implementations

Copy link

Member

javiereguiluz commentedMay 7, 2025

Let's ask@Spomky. Could you please tell us if the example currently shown on Symfony Docs works and is valid? If it is, I think we should display both the current example and the new proposed ones (so folks don't overcomplicate things when not necessary). Thanks!

Copy link

Contributor

Spomky commentedMay 7, 2025

Hi@alamirault and@javiereguiluz,

Yes, the example looks good.
The storage strategy is entirely up to the developers and in this example it is simply a folder-based approach.

The purpose of theSmimeCertificateRepositoryInterface is to resolve the certificate file path for a given email address, as the S/MIME encrypter expects a valid local file path to the certificate.

Spomky suggested changes

May 7, 2025

View reviewed changes

mailer.rst

		;
		};

		The ``repository`` option must be a service ID that implements
		:class:`Symfony\\Component\\Mailer\\EventListener\\SmimeCertificateRepositoryInterface`::

Copy link

Contributor

SpomkyMay 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

The purpose of the methodSmimeCertificateRepositoryInterface::findCertificatePathFor is to resolve the certificate file path for a given email address, as the S/MIME encrypter expects a valid local file path to the certificate.