Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork5.2k
Added information about the new form(), form_start() and form_end() helpers#2092
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
The |
@wouterj I suggest that this change be made in a separate PR. |
@bschussek I meant the |
| @@ -613,12 +605,12 @@ of code. Of course, you'll usually need much more flexibility when rendering: | |||
| {{ form_rest(form) }} | |||
| <input type="submit" /> | |||
| </form> | |||
| {{ form_end() }} | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
should beform_end(form) and the form_rest would not be needed anymore.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Fixed
I don't understand. As far as I see all the arguments in the Twig reference are named "variables", not "vars". Also I fail to see how Twig could take advantage of named arguments here. If you checkFormExtension.php, there is no specification of the function arguments. |
Indeed, as you are using a custom node, the named arguments will not be supported unless you add it in your custom node |
Consequently I think this change can be postponed to when this will be supported. Right now, the Twig reference is consistent: All methods indicate the parameter |
Rebased on master |
This PR was merged into the master branch.Discussion----------[2.3] [Form] Implemented form processorsBug fix: noFeature addition: yesBackwards compatibility break: noSymfony2 tests pass: yesFixes the following tickets: partially#5493Todo: -License of the code: MITDocumentation PR:symfony/symfony-docs#2092Commits-------11fee06 [TwigBridge] Removed duplicate entries from the CHANGELOG68f360c [Form] Moved upgrade nodes to UPGRADE-3.001b71a4 [Form] Removed trigger_error() for deprecations as of 3.081f8c67 [Form] Implemented form processors0ea75db [Form] Improved FormRenderer::renderBlock() to be usable outside of form blocks
I added information about request handlers now. |
This can be merged. |
[WCM] Added information about the new form(), form_start() and form_end() helpers
Hey Mr Bernhard! I've merged this in with minor tweaks at sha:adf8989. I've kept a reference to the old "bind" method so that if people look for it, they'll find the explanation of why it's changed. You did a nice job covering all the different areas that needed to be updated, so I think we're in great shape. If you see any tweaks that need to be made to my tweaks, let me know. Thanks! |
Thank you so much Ryan! :) 👍 |
This PR was merged into the master branch.Discussion----------[Form] Renamed form processors to request handlers| Q | A| ------------- | ---| Bug fix? | no| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets | -| License | MIT| Doc PR |symfony/symfony-docs#2092Commits-------ae7c378 [Form] Renamed form processors to request handlers
Documentation forsymfony/symfony#6522 andsymfony/symfony#7732.