Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[Validator] Highlightextensions instead ofmimeTypes forFile constraint#20893

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
xabbuh merged 1 commit intosymfony:6.4frombenito103e:patch-4
May 18, 2025

Conversation

benito103e
Copy link
Contributor

You should always use the extensions option instead of mimeTypes except if you explicitly don't want to check that the extension of the file is consistent with its content (this can be a security issue).

By default, the extensions option also checks the media type of the file.

@carsonbotcarsonbot changed the titleHighligh 'extensions' instead of 'mimeTypes' for File constraint[Validator] Highligh 'extensions' instead of 'mimeTypes' for File constraintApr 16, 2025
@javiereguiluzjaviereguiluz added this to the6.4 milestoneApr 16, 2025
Copy link
Member

@javiereguiluzjaviereguiluz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I think this is OK, but let's wait for more reviews.

Thanks!

benito103e reacted with thumbs up emoji
@OskarStarkOskarStark changed the title[Validator] Highligh 'extensions' instead of 'mimeTypes' for File constraint[Validator] Highlightextensions instead ofmimeTypes forFile constraintMay 16, 2025
Copy link
Member

@xabbuhxabbuh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

You should always use the extensions option instead of mimeTypes except if you explicitly don't want to check that the extension of the file is consistent with its content (this can be a security issue).By default, the extensions option also checks the media type of the file.
@xabbuhxabbuh changed the base branch from7.2 to6.4May 18, 2025 11:00
@xabbuh
Copy link
Member

Thank you@benito103e.

benito103e reacted with thumbs up emoji

@xabbuhxabbuh merged commitaafade6 intosymfony:6.4May 18, 2025
3 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@javiereguiluzjaviereguiluzjaviereguiluz approved these changes

@xabbuhxabbuhxabbuh approved these changes

Assignees
No one assigned
Projects
None yet
Milestone
6.4
Development

Successfully merging this pull request may close these issues.

4 participants
@benito103e@xabbuh@javiereguiluz@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp