I did not listed theAsTwigTest attribute in the attributes list as no doc make mention of use case of this attribute. Do I had it anyway without any link to it (or a link to thetwig documentation)?

Also I hope my wording is correct, feel free to ask me any adjustment 😄

I followed the plan of@javiereguiluz

carsonbot added the Status: Needs Review label

Apr 12, 2025

carsonbot added this to the7.3 milestone

Apr 12, 2025

Copy link

ContributorAuthor

RisingSunLight42 commentedApr 12, 2025

I have no clue why the CI fails to build the docs, I can build it properly on my end 😞

Fan2Shrek reviewed

Apr 13, 2025

View reviewed changes

quick_tour/the_architecture.rst OutdatedShow resolvedHide resolved

GromNaN reviewed

Apr 13, 2025

View reviewed changes

Copy link

Member

GromNaN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I've added a few comments. I find it hard to juggle the old and new ways of doing things in the same doc without making it too complex to understand; but it looks fine to me the way it is.

quick_tour/the_architecture.rst OutdatedShow resolvedHide resolved

templates.rst OutdatedShow resolvedHide resolved

templates.rstShow resolvedHide resolved

templates.rst OutdatedShow resolvedHide resolved

Copy link

ContributorAuthor

RisingSunLight42 commentedApr 13, 2025

Thanks for the comment GromNan, it's very appreciated especially since I'm still new to the doc repository. I'm slowly starting to get the hang of how to write it 🎉. I'll apply your suggestions tomorrow 😄

alamirault approved these changes

Apr 23, 2025

View reviewed changes

carsonbot added Status: Reviewed and removed Status: Needs Review labels

Apr 23, 2025

GromNaN suggested changes

Apr 24, 2025

View reviewed changes

quick_tour/the_architecture.rst OutdatedShow resolvedHide resolved

templates.rst OutdatedShow resolvedHide resolved

carsonbot added Status: Needs Work and removed Status: Reviewed labels

Apr 24, 2025

OskarStark changed the title~~[TwigBundle] Enable #[AsTwigFilter], #[AsTwigFunction] and#[AsTwigTest]~~[TwigBundle] Enable#[AsTwigFilter],#[AsTwigFunction] and#[AsTwigTest]

Apr 24, 2025

carsonbot added Status: Needs Review and removed Status: Needs Work labels

Apr 28, 2025

RisingSunLight42 requested a review fromGromNaN

April 28, 2025 16:02

GromNaN approved these changes

Apr 28, 2025

View reviewed changes

carsonbot added Status: Reviewed and removed Status: Needs Review labels

Apr 28, 2025

xabbuh reviewed

Apr 28, 2025

View reviewed changes

reference/attributes.rst

		@@ -123,6 +123,8 @@ Twig
		~~~~

		* :ref:`Template <templates-template-attribute>`
		* :ref:`AsTwigFilter <templates-twig-filter-attribute>`
		* :ref:`AsTwigFunction <templates-twig-function-attribute>`

Copy link

Member

xabbuhApr 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

What about also adding something for the#[AsTwigTest] attribute?

Copy link

Member

javiereguiluzApr 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I added#[AsTwigTest] to the list, but just as text, without any link to it. I think this is rare enough to not explain it and just mention that it exists. Thanks.

xabbuh reviewed

Apr 28, 2025

View reviewed changes

quick_tour/the_architecture.rst

		@@ -197,8 +190,8 @@ After creating just one file, you can use this immediately:
		{# templates/default/index.html.twig #}
		{# Will print something like "Hey Symfony!" #}
		<h1>{{ name\|greet }}</h1>

		How does this work? Symfony notices that your class extends ``AbstractExtension``