symfony/symfony-docsPublic

NotificationsYou must be signed in to change notification settings
Fork5.2k
Star2.3k

[Validator] Add docs for bridge twig validator #20836#20863

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

javiereguiluz merged 1 commit intosymfony:7.3fromsfmok:docs/bridge-twig-validator

Apr 10, 2025

Merged

[Validator] Add docs for bridge twig validator #20836#20863

javiereguiluz merged 1 commit intosymfony:7.3fromsfmok:docs/bridge-twig-validator

Apr 10, 2025

Conversation

Copy link

Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Suggested change

	Twig template:

	..code-block::php
	Twig template::

OskarStark reviewed

Apr 7, 2025

View reviewed changes

bridge/twig/validation.rst Outdated

Comment on lines 53 to 55

		set this to `false`.

		.. code-block:: php

Copy link

Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Suggested change

	set this to `false`.

	..code-block::php
	set this to `false`::

sfmok force-pushed thedocs/bridge-twig-validator branch from90b3c8e to7f3faf7Compare

April 8, 2025 18:54

Add docs for bridge twig validatorsymfony#20836

ac9e20c

sfmok force-pushed thedocs/bridge-twig-validator branch from7f3faf7 toac9e20cCompare

April 8, 2025 19:05

Copy link

ContributorAuthor

sfmok commentedApr 8, 2025

@OskarStark done, but I think this#20872 needs to be merged first

javiereguiluz added Validator Status: Reviewed and removed Status: Needs Review labels

Apr 10, 2025

carsonbot changed the title~~Add docs for bridge twig validator #20836~~[Validator] Add docs for bridge twig validator #20836

Apr 10, 2025

javiereguiluz merged commit6a73077 intosymfony:7.3

Apr 10, 2025

2 of 3 checks passed

sfmok deleted the docs/bridge-twig-validator branch

April 10, 2025 07:16

Copy link

Member

javiereguiluz commentedApr 10, 2025

@sfmok thanks a lot for contributing these docs!

Your contribution was perfectly correct, but we changed some things while merging. The fact that this constraint is stored in the Twig Bridge is an "implementation detail" that most users don't care about. We have other similar constraints (e.g.UniqueEntity from Doctrine Bridge) that are documented like a normal constraint, without explaining in detail that it belongs to a bridge.

So, we made some changes (see344d8ba) to remove the newtwig_bridge/ docs and move the contents toreference/constraints/Twig.rst.

Also, even if the constraint page titles only use the name of the constraint (e.g. justJson,IsNull, etc.) we decided to title the new page asTwig Constraint to avoid confusion with the pages related to Twig templating (in Google search results, in symfony.com search engine, etc.)

Thanks!

Copy link

ContributorAuthor

sfmok commentedApr 10, 2025

@sfmok thanks a lot for contributing these docs!
Your contribution was perfectly correct, but we changed some things while merging. The fact that this constraint is stored in the Twig Bridge is an "implementation detail" that most users don't care about. We have other similar constraints (e.g.UniqueEntity from Doctrine Bridge) that are documented like a normal constraint, without explaining in detail that it belongs to a bridge.
So, we made some changes (see344d8ba) to remove the newtwig_bridge/ docs and move the contents toreference/constraints/Twig.rst.
Also, even if the constraint page titles only use the name of the constraint (e.g. justJson,IsNull, etc.) we decided to title the new page asTwig Constraint to avoid confusion with the pages related to Twig templating (in Google search results, in symfony.com search engine, etc.)
Thanks!

Got it, that makes perfect sense. Thanks!