Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork5.2k
Update framework.rst#20852
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Update framework.rst#20852
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Docs correction
It looks like you unchecked the "Allow edits from maintainer" box. That is fine, but please note that if you have multiple commits, you'll need to squash your commits into one before this can be merged. Or, you can check the "Allow edits from maintainers" box and the maintainer can squash for you. Cheers! Carsonbot |
MrYamous left a comment• edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
We may can remove the default value at the end of the description
Btw looks good for 6.4
| @@ -1239,7 +1239,7 @@ http_cache | |||
| allow_reload | |||
| ............ | |||
| **type**: ``string`` | |||
| **type**: ``boolean`` **default**: ``false`` | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
strictly spoken, the default value isnull but that in turn is treated asfalse in theHttpCache class
This PR was submitted for the 7.2 branch but it was merged into the 6.4 branch instead.Discussion----------Update framework.rstDocs correction<!--If your pull request fixes a BUG, use the oldest maintained branch that containsthe bug (seehttps://symfony.com/releases for the list of maintained branches).If your pull request documents a NEW FEATURE, use the same Symfony branch wherethe feature was introduced (and `7.x` for features of unreleased versions).-->Commits-------ca92b57 Update framework.rst
Thanks Ruben ... and congrats on your first Symfony Docs contribution 🎉 |
this was merged in6e0d1c3 even though the PR is displayed as closed (that's because we merged it into a different branch than you targetted with your PR) |
…aviereguiluz)This PR was merged into the 6.4 branch.Discussion----------[Reference] Update the default values of some optionsAfter merging#20852 I realized that some default option values were not following the format used in most options, so let's update them.Commits-------5028721 [Reference] Update the default values of some options
Docs correction