Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork5.2k
[Messenger] Document stamps in HandleTrait::handle#20851
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Spomky commentedApr 2, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Hi@Fan2Shrek, This looks good to me. |
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
After my comment
messenger.rst Outdated
| @@ -2512,6 +2512,15 @@ wherever you need a query bus behavior instead of the ``MessageBusInterface``:: | |||
| } | |||
| } | |||
| You also can also specify stamps when handling a message. For example, you can | |||
javiereguiluzApr 2, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
What doesspecify mean here? Is it about adding new stamps to the message? What if you add a stamp of the same type that some existing stamp: is it appended or overwritten? Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Good points! I committed some refinements. Does it look good to you?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Fine for me👌.
Many thanks.
59836aa intosymfony:7.3Uh oh!
There was an error while loading.Please reload this page.
Merged! Thanks Pierre. |
| @@ -2512,6 +2512,20 @@ wherever you need a query bus behavior instead of the ``MessageBusInterface``:: | |||
| } | |||
| } | |||
| You also can also add stamps when handling a message. For example, you can | |||
| add an ``DoctrineFlushStamp`` to flush the entity manager after handling the message:: | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This stamp doss not exists in the symfony core maybe we should alternative or describe it as MyCustomStamp.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Oops, I'll take a look at it later today 😅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thanks Alexander! I wasn't aware of this.
We updated the example directly in7f9f20f but if you think this needs further changes, please create a Pull Request. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Looks good@javiereguiluz 👍
Fix#20842