Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork5.2k
[PropertyInfo] DeprecateType
#20821
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:7.3
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
friendly ping@mtarld |
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
@@ -303,32 +305,32 @@ Each object will provide 6 attributes, available in the 6 methods: | |||
``Type::getBuiltInType()`` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
All of these methods are kind of removed:
getBuiltinType
is the same asgetTypeIdentifier
ofBuiltinType
andObjectType
isNullable
still existsgetClassName
only exists onObjectType
isCollection
is the equivalent of$type instanceof CollectionType
getCollection[Key|Value]Types
is the same asgetCollection[Key|Value]Type
ofCollectionType
TheType
ofTypeInfo
is really different from the one fromPropertyInfo
, so I think we might rewrite that part completely.
Or maybe redirect to the doc related to TypeInfo'sType
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thanks, I missed those differences.
Maybe we can remove this part fromPropertyInfo Type
doc as the class is deprecated and updateTypeInfo
doc with appropriate methods ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I would also not mix the TypeInfo things into the doc of PropertyInfo
Co-authored-by: Oskar Stark <oskarstark@googlemail.com>Co-authored-by: Mathias Arlaud <mathias.arlaud@gmail.com>
private $builtinType => string(6) "string" | ||
private $nullable => bool(false) | ||
private $class => NULL | ||
private $collection => bool(false) | ||
private $collectionKeyType => NULL | ||
private $collectionValueType => NULL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This is not what theType
class (fromtype-info
) contains.
Fixes#20799