Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[PropertyInfo] DeprecateType#20821

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
MrYamous wants to merge3 commits intosymfony:7.3
base:7.3
Choose a base branch
Loading
fromMrYamous:property-info/deprecate-type

Conversation

MrYamous
Copy link
Contributor

Fixes#20799

@OskarStark
Copy link
Contributor

friendly ping@mtarld

@@ -303,32 +305,32 @@ Each object will provide 6 attributes, available in the 6 methods:
``Type::getBuiltInType()``
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

All of these methods are kind of removed:

  • getBuiltinType is the same asgetTypeIdentifier ofBuiltinType andObjectType
  • isNullable still exists
  • getClassName only exists onObjectType
  • isCollection is the equivalent of$type instanceof CollectionType
  • getCollection[Key|Value]Types is the same asgetCollection[Key|Value]Type ofCollectionType

TheType ofTypeInfo is really different from the one fromPropertyInfo, so I think we might rewrite that part completely.

Or maybe redirect to the doc related to TypeInfo'sType?

Copy link
ContributorAuthor

@MrYamousMrYamousMar 25, 2025
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks, I missed those differences.
Maybe we can remove this part fromPropertyInfo Type doc as the class is deprecated and updateTypeInfo doc with appropriate methods ?

mtarld reacted with thumbs up emoji
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I would also not mix the TypeInfo things into the doc of PropertyInfo

xabbuh reacted with thumbs up emoji
Co-authored-by: Oskar Stark <oskarstark@googlemail.com>Co-authored-by: Mathias Arlaud <mathias.arlaud@gmail.com>
Comment on lines +172 to +177
private $builtinType => string(6) "string"
private $nullable => bool(false)
private $class => NULL
private $collection => bool(false)
private $collectionKeyType => NULL
private $collectionValueType => NULL
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This is not what theType class (fromtype-info) contains.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@OskarStarkOskarStarkOskarStark left review comments

@mtarldmtarldmtarld requested changes

Assignees
No one assigned
Projects
None yet
Milestone
7.3
Development

Successfully merging this pull request may close these issues.

[PropertyInfo] DeprecateType
4 participants
@MrYamous@OskarStark@mtarld@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp