Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Clock] documentDatePointType#20817

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
javiereguiluz merged 1 commit intosymfony:7.3fromgarak:datepoint-type
Mar 25, 2025
Merged

Conversation

garak
Copy link
Contributor

@carsonbotcarsonbot added this to the7.3 milestoneMar 24, 2025
@carsonbotcarsonbot changed the titledocument DatePointType[Clock] document DatePointTypeMar 24, 2025
@OskarStarkOskarStark changed the title[Clock] document DatePointType[Clock] documentDatePointTypeMar 24, 2025
#[ORM\Entity(repositoryClass: ProductRepository::class)]
class Product
{
#[ORM\Column(type: DatePointType::NAME)]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Suggested change
#[ORM\Column(type: DatePointType::NAME)]
#[ORM\Column(type: DatePointType::class)]

couldn't we use::class here? 🤔

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I'd even removetype since it's auto-detected from the property type

@javiereguiluzjaviereguiluz merged commit2d7f46c intosymfony:7.3Mar 25, 2025
2 of 3 checks passed
@javiereguiluz
Copy link
Member

Thanks Massimiliano!

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@OskarStarkOskarStarkOskarStark left review comments

@ycerutoycerutoyceruto left review comments

Assignees
No one assigned
Projects
None yet
Milestone
7.3
Development

Successfully merging this pull request may close these issues.

[DoctrineBridge] add newDatePointType Doctrine type
5 participants
@garak@javiereguiluz@OskarStark@yceruto@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp