Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork5.2k
[Security] Simplifying the DEV firewall's pattern#20794
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:6.4
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Changes fromall commits
File filter
Filter by extension
Conversations
Uh oh!
There was an error while loading.Please reload this page.
Jump to
Uh oh!
There was an error while loading.Please reload this page.
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
@@ -497,7 +497,7 @@ | ||||||
# the order in which firewalls are defined is very important, as the | ||||||
# request will be handled by the first firewall whose pattern matches | ||||||
dev: | ||||||
pattern: ^/_profiler|_wdt|assets|build/ # `assets` is for AssetMapper; `build` is for Webpack Encore | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others.Learn more. Suggested change
| ||||||
security: false | ||||||
# a firewall with no pattern should be defined last because it will match all requests | ||||||
main: | ||||||
@@ -509,7 +509,7 @@ | ||||||
# https://symfony.com/doc/current/security.html#firewalls-authentication | ||||||
# https://symfony.com/doc/current/security/impersonating_user.html | ||||||
# switch_user: true | ||||||
Check failure on line 512 in security.rst
| ||||||
.. code-block:: xml | ||||||
@@ -529,8 +529,8 @@ | ||||||
<!-- the order in which firewalls are defined is very important, as the | ||||||
request will be handled by the first firewall whose pattern matches --> | ||||||
<firewall name="dev" | ||||||
pattern="^/_profiler|_wdt|assets|build/" | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others.Learn more. Suggested change
| ||||||
security="false"/> <!-- `assets` is for AssetMapper; `build` is for Webpack Encore --> | ||||||
<!-- a firewall with no pattern should be defined last because it will match all requests --> | ||||||
<firewall name="main" | ||||||
@@ -555,7 +555,7 @@ | ||||||
// the order in which firewalls are defined is very important, as the | ||||||
// request will be handled by the first firewall whose pattern matches | ||||||
$security->firewall('dev') | ||||||
->pattern('^/_profiler|_wdt|assets|build/') // `assets` is for AssetMapper; `build` is for Webpack Encore | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others.Learn more. Suggested change
| ||||||
->security(false) | ||||||
; | ||||||
@@ -598,9 +598,7 @@ | ||||||
pattern: | ||||||
- ^/_profiler/ | ||||||
- ^/_wdt/ | ||||||
- ^/assets/ | ||||||
# ... | ||||||
.. code-block:: php | ||||||
@@ -614,9 +612,7 @@ | ||||||
->pattern([ | ||||||
'^/_profiler/', | ||||||
'^/_wdt/', | ||||||
'^/assets/', | ||||||
]) | ||||||
->security(false) | ||||||
; | ||||||
Uh oh!
There was an error while loading.Please reload this page.