Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork5.2k
[Messenger] Keepalive support for Doctrine & Redis#20721
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
| The keepalive feature, which prevents messages from being prematurely redelivered during | ||
| long-running processing, updates the ``delivered_at`` timestamp periodically to ensure | ||
| the message is marked as "in progress". |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I don't think this is needed since no other transport has an explanation of how the keepalive mechanism is implemented and I'm not sure it's even relevant.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
While this is an implementation detail, it could be helpful to understand the how, that said, its ok for me to remove it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Maybe we could add a similar explanation for each transport that has the keepalive mechanism implemented?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Yes 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Done, see#20736 for 7.2
…ansport (HypeMC)This PR was merged into the 7.2 branch.Discussion----------[Messenger] Clarify keepalive implementation for each transportAs discussed with `@OskarStark` in#20721, this PR clarifies how the keepalive mechanism is implemented for each transport.Commits-------d49a86a [Messenger] Clarify keepalive implementation for each transport
And another nice PR! Thanks |
a8fc6c5 intosymfony:7.3Uh oh!
There was an error while loading.Please reload this page.
This PR was merged into the 7.3 branch.Discussion----------[Messenger] Fix link to classI broke this in#20721.Commits-------0b9fbc1 [Messenger] Fix link to class
Uh oh!
There was an error while loading.Please reload this page.
Contains#20736 which should be merged first.
Keepalive support for the Doctrine and Redis transports was added insymfony/symfony#59601 andsymfony/symfony#59360, respectively.